Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(document): add plot test #2245

Merged
merged 2 commits into from
Apr 2, 2021
Merged

test(document): add plot test #2245

merged 2 commits into from
Apr 2, 2021

Conversation

Yongxuanzhang
Copy link
Contributor

complete the test of document.plot()

@jina-bot jina-bot added size/XS area/testing This issue/PR affects testing labels Mar 27, 2021
@codecov
Copy link

codecov bot commented Mar 27, 2021

Codecov Report

Merging #2245 (baa3cf5) into master (4fa7af2) will increase coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2245      +/-   ##
==========================================
+ Coverage   90.62%   90.75%   +0.12%     
==========================================
  Files         209      209              
  Lines       11311    11311              
==========================================
+ Hits        10251    10265      +14     
+ Misses       1060     1046      -14     
Flag Coverage Δ
daemon 51.18% <ø> (ø)
jina 91.22% <ø> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/types/document/__init__.py 95.64% <0.00%> (+3.38%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fa7af2...baa3cf5. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Mar 27, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1049, delta to last 3 avg.: +4%
  • 🐢🐢 query QPS at 14, delta to last 3 avg.: -7%

Breakdown

Version Index QPS Query QPS
current 1049 14
1.0.16 1007 15

Backed by latency-tracking. Further commits will update this comment.

@Yongxuanzhang Yongxuanzhang marked this pull request as ready for review March 30, 2021 12:54
@Yongxuanzhang Yongxuanzhang requested a review from a team as a code owner March 30, 2021 12:54
@hanxiao hanxiao merged commit 6cbcc45 into master Apr 2, 2021
@hanxiao hanxiao deleted the test-document-plot branch April 2, 2021 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing This issue/PR affects testing size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants