Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: use latest endpoint for tests #2251

Merged
merged 5 commits into from
Apr 2, 2021
Merged

test: use latest endpoint for tests #2251

merged 5 commits into from
Apr 2, 2021

Conversation

bwanglzu
Copy link
Member

@bwanglzu bwanglzu commented Mar 29, 2021

none examples/tests are using the latest APIs, can we provide some examples and test code?

@bwanglzu bwanglzu self-assigned this Mar 29, 2021
@jina-bot jina-bot added size/XS area/testing This issue/PR affects testing labels Mar 29, 2021
@github-actions
Copy link

github-actions bot commented Mar 29, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 794, delta to last 3 avg.: -1%
  • 😶 query QPS at 11, delta to last 3 avg.: -5%

Breakdown

Version Index QPS Query QPS
current 794 11
1.1.0 784 11
1.0.16 819 11

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link

codecov bot commented Mar 29, 2021

Codecov Report

Merging #2251 (105af5e) into master (2ad1a5e) will increase coverage by 0.84%.
The diff coverage is 100.00%.

❗ Current head 105af5e differs from pull request most recent head 85ce870. Consider uploading reports for the commit 85ce870 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2251      +/-   ##
==========================================
+ Coverage   87.82%   88.67%   +0.84%     
==========================================
  Files         209      209              
  Lines       11313    11313              
==========================================
+ Hits         9936    10032      +96     
+ Misses       1377     1281      -96     
Flag Coverage Δ
daemon 51.17% <100.00%> (ø)
jina 89.03% <100.00%> (+0.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/__init__.py 73.49% <100.00%> (ø)
jina/helloworld/chatbot/__init__.py 0.00% <0.00%> (-32.15%) ⬇️
jina/helloworld/helper.py 0.00% <0.00%> (-27.09%) ⬇️
jina/peapods/runtimes/asyncio/grpc/async_call.py 74.07% <0.00%> (-20.38%) ⬇️
jina/peapods/runtimes/asyncio/rest/app.py 86.33% <0.00%> (-7.20%) ⬇️
jina/importer.py 96.19% <0.00%> (-0.96%) ⬇️
jina/logging/profile.py 92.18% <0.00%> (-0.79%) ⬇️
jina/helper.py 81.43% <0.00%> (+1.05%) ⬆️
jina/clients/base.py 82.64% <0.00%> (+1.65%) ⬆️
jina/drivers/control.py 95.00% <0.00%> (+1.66%) ⬆️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 971d8c1...85ce870. Read the comment docs.

@jina-bot jina-bot added size/S and removed size/XS labels Mar 30, 2021
@bwanglzu bwanglzu changed the title test: use latest endpoint for system test test: use latest endpoint for tests Mar 30, 2021
@bwanglzu bwanglzu marked this pull request as ready for review March 30, 2021 07:03
@bwanglzu bwanglzu requested a review from a team as a code owner March 30, 2021 07:03
@bwanglzu bwanglzu requested a review from CatStark March 30, 2021 07:03
cristianmtr
cristianmtr previously approved these changes Mar 30, 2021
nan-wang
nan-wang previously approved these changes Mar 30, 2021
Copy link
Member

@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@deepankarm deepankarm dismissed stale reviews from nan-wang and cristianmtr via 85ce870 April 1, 2021 17:29
@jina-bot jina-bot added area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality component/peapod labels Apr 1, 2021
@hanxiao hanxiao merged commit 2c96303 into master Apr 2, 2021
@hanxiao hanxiao deleted the test-new-api-endpoint branch April 2, 2021 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/peapod size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants