Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: router cancel request #2257

Merged
merged 10 commits into from
Mar 31, 2021
Merged

feat: router cancel request #2257

merged 10 commits into from
Mar 31, 2021

Conversation

florian-hoenicke
Copy link
Member

@jina-bot jina-bot added size/XL area/core This issue/PR affects the core codebase area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/driver component/peapod component/proto component/type labels Mar 29, 2021
@codecov
Copy link

codecov bot commented Mar 29, 2021 •
edited

Codecov Report

Merging #2257 (fcfdde5) into master (0946a46) will increase coverage by 0.11%.
The diff coverage is 96.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2257      +/-   ##
==========================================
+ Coverage   90.56%   90.68%   +0.11%     
==========================================
  Files         209      209              
  Lines       11335    11352      +17     
==========================================
+ Hits        10265    10294      +29     
+ Misses       1070     1058      -12
Flag Coverage Δ
daemon 51.27% <96.15%> (+0.07%) ⬆️
jina 91.14% <96.15%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/proto/jina_pb2.py 100.00% <ø> (ø)
jina/types/message/common.py 100.00% <ø> (ø)
jina/peapods/zmq/__init__.py 84.13% <94.44%> (+3.32%) ⬆️
jina/__init__.py 73.49% <100.00%> (ø)
jina/drivers/control.py 95.45% <100.00%> (+0.45%) ⬆️
jina/clients/base.py 82.64% <0.00%> (+2.47%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0946a46...fcfdde5. Read the comment docs.

JoanFM
JoanFM approved these changes Mar 29, 2021
View reviewed changes
jina/proto/jina.proto Outdated Show resolved Hide resolved
jina/proto/jina.proto Outdated Show resolved Hide resolved
JoanFM
JoanFM requested changes Mar 29, 2021
View reviewed changes
Copy link
Member

@JoanFM JoanFM left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comments above

@github-actions
Copy link

github-actions bot commented Mar 29, 2021 •
edited

Latency summary

Current PR yields:

  • 😶 index QPS at 1118, delta to last 3 avg.: +0%
  • 😶 query QPS at 18, delta to last 3 avg.: -3%

Breakdown

Version Index QPS Query QPS
current 1118 18
1.1.0 1118 19
1.0.16 1114 18

Backed by latency-tracking. Further commits will update this comment.

@jina-bot jina-bot added size/S and removed size/XL labels Mar 29, 2021
JoanFM
JoanFM approved these changes Mar 30, 2021
View reviewed changes
Copy link
Member

@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

JoanFM
JoanFM requested changes Mar 30, 2021
View reviewed changes
jina/peapods/zmq/__init__.py Outdated Show resolved Hide resolved
@florian-hoenicke florian-hoenicke marked this pull request as ready for review March 30, 2021 16:03
@florian-hoenicke florian-hoenicke requested a review from a team as a code owner March 30, 2021 16:03
JoanFM
JoanFM reviewed Mar 30, 2021
View reviewed changes
jina/peapods/zmq/__init__.py Outdated
try:
self._send_cancel_to_router()
except:
pass # in case the router is down already it throws an exception which can be silently ignored
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would only silence TimeOutError which may be a normal way to end, but the other exceptions I would still log them. What have u been seing?

@cristianmtr cristianmtr mentioned this pull request Mar 31, 2021
Merged
cristianmtr
cristianmtr previously approved these changes Mar 31, 2021
View reviewed changes
@cristianmtr
Copy link
Contributor

Need to rebase and address some broken tests

@JoanFM JoanFM changed the title feat: router busy request feat: router cancel request Mar 31, 2021
@cristianmtr
Copy link
Contributor

One test still failing. Seems to be timing out again

@florian-hoenicke florian-hoenicke merged commit 6228128 into master Mar 31, 2021
@florian-hoenicke florian-hoenicke deleted the feat-router-busy-request branch March 31, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cristianmtr cristianmtr cristianmtr approved these changes

@JoanFM JoanFM JoanFM approved these changes

@davidbp davidbp Awaiting requested review from davidbp

@nan-wang nan-wang Awaiting requested review from nan-wang

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/driver component/peapod component/proto component/type size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@florian-hoenicke @cristianmtr @JoanFM @jina-bot