Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove unnecessary code #2258

Merged
merged 1 commit into from
Mar 30, 2021
Merged

refactor: remove unnecessary code #2258

merged 1 commit into from
Mar 30, 2021

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Mar 30, 2021

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner March 30, 2021 07:00
@jina-bot jina-bot added size/XS area/core This issue/PR affects the core codebase component/driver labels Mar 30, 2021
@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #2258 (53800f9) into master (ec55e7d) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2258      +/-   ##
==========================================
- Coverage   90.62%   90.62%   -0.01%     
==========================================
  Files         209      209              
  Lines       11312    11311       -1     
==========================================
- Hits        10252    10251       -1     
  Misses       1060     1060              
Flag Coverage Δ
daemon 51.18% <ø> (+<0.01%) ⬆️
jina 91.09% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/drivers/rank/aggregate/__init__.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec55e7d...53800f9. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1111, delta to last 3 avg.: +0%
  • 😶 query QPS at 18, delta to last 3 avg.: -4%

Breakdown

Version Index QPS Query QPS
current 1111 18
1.1.0 1101 18
1.0.16 1125 18

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 4fa7af2 into master Mar 30, 2021
@hanxiao hanxiao deleted the small-cleanup branch March 30, 2021 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase component/driver size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants