Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helper): fetching external ip is extremely slow #2267

Merged
merged 2 commits into from
Apr 1, 2021

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Apr 1, 2021

  • fetching external ip is slow in china because of the network issue.
  • the original implementation fetch IP sequentially, called twice
  • *with timeout at 1, in China mainland it takes (1+1+1)2 = 6s to start at Flow!
  • change it to async and smaller timeout

@hanxiao hanxiao requested a review from a team as a code owner April 1, 2021 03:41
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality labels Apr 1, 2021
@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #2267 (6cc7fb2) into master (6228128) will decrease coverage by 6.89%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2267      +/-   ##
==========================================
- Coverage   90.59%   83.69%   -6.90%     
==========================================
  Files         209      209              
  Lines       11352    11357       +5     
==========================================
- Hits        10284     9505     -779     
- Misses       1068     1852     +784     
Flag Coverage Δ
daemon 51.28% <100.00%> (+<0.01%) ⬆️
jina 83.75% <100.00%> (-7.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/helper.py 70.35% <100.00%> (-13.41%) ⬇️
jina/schemas/pod.py 0.00% <0.00%> (-100.00%) ⬇️
jina/schemas/flow.py 0.00% <0.00%> (-100.00%) ⬇️
jina/schemas/meta.py 0.00% <0.00%> (-100.00%) ⬇️
jina/schemas/driver.py 0.00% <0.00%> (-100.00%) ⬇️
jina/schemas/request.py 0.00% <0.00%> (-100.00%) ⬇️
jina/schemas/executor.py 0.00% <0.00%> (-100.00%) ⬇️
jina/helloworld/fashion/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
jina/schemas/__init__.py 7.14% <0.00%> (-92.86%) ⬇️
jina/helloworld/multimodal/__init__.py 0.00% <0.00%> (-90.91%) ⬇️
... and 51 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49ed5c3...6cc7fb2. Read the comment docs.

@hanxiao hanxiao merged commit afb3ce3 into master Apr 1, 2021
@hanxiao hanxiao deleted the fix-external-ip-slow branch April 1, 2021 03:57
@github-actions
Copy link

github-actions bot commented Apr 1, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 978, delta to last 3 avg.: -2%
  • 😶 query QPS at 14, delta to last 3 avg.: -4%

Breakdown

Version Index QPS Query QPS
current 978 14
1.1.0 1006 14
1.0.16 989 14

Backed by latency-tracking. Further commits will update this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants