Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: import warnings verbose off by default #2271

Merged
merged 8 commits into from
Apr 2, 2021

Conversation

davidbp
Copy link
Contributor

@davidbp davidbp commented Apr 1, 2021

This PR:

  • Avoids warning users of external packages with specific arrays that are allowed in documents
  • Refactors update_ndarray code making it more compact
  • fixes protbuff_updater mispelled variable names to protbuf_updater

@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase component/type labels Apr 1, 2021
@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #2271 (61f3214) into master (afb3ce3) will increase coverage by 1.20%.
The diff coverage is 98.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2271      +/-   ##
==========================================
+ Coverage   87.32%   88.53%   +1.20%     
==========================================
  Files         209      209              
  Lines       11357    11386      +29     
==========================================
+ Hits         9918    10081     +163     
+ Misses       1439     1305     -134     
Flag Coverage Δ
daemon 51.15% <16.00%> (-0.14%) ⬇️
jina 88.84% <98.00%> (+1.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/types/document/__init__.py 92.37% <97.87%> (+0.36%) ⬆️
jina/__init__.py 74.41% <100.00%> (+0.92%) ⬆️
jina/helper.py 83.09% <0.00%> (+0.21%) ⬆️
jina/executors/indexers/keyvalue.py 99.26% <0.00%> (+0.73%) ⬆️
jina/types/sets/document.py 88.72% <0.00%> (+0.75%) ⬆️
jina/drivers/search.py 98.18% <0.00%> (+1.81%) ⬆️
jina/peapods/pods/__init__.py 90.00% <0.00%> (+1.87%) ⬆️
jina/peapods/zmq/__init__.py 84.13% <0.00%> (+2.09%) ⬆️
jina/clients/base.py 80.99% <0.00%> (+2.47%) ⬆️
jina/types/sets/chunk.py 95.83% <0.00%> (+4.16%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afb3ce3...61f3214. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Apr 1, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 945, delta to last 3 avg.: +0%
  • 😶 query QPS at 14, delta to last 3 avg.: +1%

Breakdown

Version Index QPS Query QPS
current 945 14
1.1.0 941 13
1.0.16 932 14

Backed by latency-tracking. Further commits will update this comment.

@davidbp davidbp requested a review from hanxiao April 1, 2021 10:20
jina/types/document/__init__.py Outdated Show resolved Hide resolved
@davidbp davidbp marked this pull request as ready for review April 1, 2021 11:22
@davidbp davidbp requested a review from a team as a code owner April 1, 2021 11:22
@davidbp davidbp requested a review from nan-wang April 1, 2021 11:22
JoanFM
JoanFM previously approved these changes Apr 1, 2021
Copy link
Member

@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@hanxiao hanxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the whole codebase is designed in a very conservative way on header logic, no heavylifting/importing is written directly in the module, they should be hided inside function/class scope

@jina-bot jina-bot added size/M area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality and removed size/S labels Apr 1, 2021
@davidbp
Copy link
Contributor Author

davidbp commented Apr 1, 2021

the whole codebase is designed in a very conservative way on header logic, no heavylifting/importing is written directly in the module, they should be hided inside function/class scope

Commit fix: reformat update ndarray to improve load time should handle this issue.

jina/types/document/__init__.py Outdated Show resolved Hide resolved
@davidbp davidbp requested review from JoanFM and hanxiao April 1, 2021 17:32
@hanxiao hanxiao merged commit 6cf7624 into master Apr 2, 2021
@hanxiao hanxiao deleted the refactor-sparse-ndarray-verbosity branch April 2, 2021 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality component/type size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants