-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: import warnings verbose off by default #2271
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2271 +/- ##
==========================================
+ Coverage 87.32% 88.53% +1.20%
==========================================
Files 209 209
Lines 11357 11386 +29
==========================================
+ Hits 9918 10081 +163
+ Misses 1439 1305 -134
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the whole codebase is designed in a very conservative way on header logic, no heavylifting/importing is written directly in the module, they should be hided inside function/class scope
Commit |
This PR:
update_ndarray
code making it more compactprotbuff_updater
mispelled variable names toprotbuf_updater