Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helper): threadpool to simple thread #2272

Merged
merged 2 commits into from
Apr 1, 2021
Merged

fix(helper): threadpool to simple thread #2272

merged 2 commits into from
Apr 1, 2021

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Apr 1, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner April 1, 2021 12:17
@hanxiao hanxiao changed the title feat(pod): add reload mechanism to pod fix(helper): threadpool to simple thread Apr 1, 2021
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality labels Apr 1, 2021
@codecov
Copy link

codecov bot commented Apr 1, 2021

Codecov Report

Merging #2272 (be279fc) into master (afb3ce3) will increase coverage by 1.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2272      +/-   ##
==========================================
+ Coverage   87.32%   88.39%   +1.06%     
==========================================
  Files         209      209              
  Lines       11357    11363       +6     
==========================================
+ Hits         9918    10044     +126     
+ Misses       1439     1319     -120     
Flag Coverage Δ
daemon 51.30% <100.00%> (+0.02%) ⬆️
jina 88.69% <100.00%> (+1.11%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/helper.py 83.09% <100.00%> (+0.21%) ⬆️
jina/types/document/__init__.py 92.25% <0.00%> (+0.24%) ⬆️
jina/drivers/__init__.py 93.90% <0.00%> (+1.21%) ⬆️
jina/drivers/evaluate.py 100.00% <0.00%> (+2.81%) ⬆️
jina/drivers/segment.py 80.64% <0.00%> (+3.22%) ⬆️
jina/types/sets/chunk.py 95.83% <0.00%> (+4.16%) ⬆️
jina/executors/indexers/cache.py 100.00% <0.00%> (+4.47%) ⬆️
jina/types/sets/document.py 94.73% <0.00%> (+6.76%) ⬆️
jina/drivers/querylang/select.py 89.65% <0.00%> (+17.24%) ⬆️
jina/executors/encoders/multimodal/__init__.py 100.00% <0.00%> (+20.00%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afb3ce3...be279fc. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Apr 1, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 938, delta to last 3 avg.: -1%
  • 😶 query QPS at 13, delta to last 3 avg.: -5%

Breakdown

Version Index QPS Query QPS
current 938 13
1.1.0 950 13
1.0.16 944 14

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 226b99e into master Apr 1, 2021
@hanxiao hanxiao deleted the fix-thread-pool branch April 1, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants