Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(driver): add whoosh driver for april fool #2273

Merged
merged 4 commits into from
Apr 1, 2021
Merged

feat(driver): add whoosh driver for april fool #2273

merged 4 commits into from
Apr 1, 2021

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Apr 1, 2021 •
edited

@hanxiao hanxiao requested a review from a team as a code owner April 1, 2021 14:27
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality component/driver component/resource labels Apr 1, 2021
Yongxuanzhang
Yongxuanzhang reviewed Apr 1, 2021
View reviewed changes
Copy link
Contributor

@Yongxuanzhang Yongxuanzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy Fool's Day 😛

@hanxiao hanxiao merged commit 56bdf8b into master Apr 1, 2021
@hanxiao hanxiao deleted the feat-april-fool branch April 1, 2021 14:30
@github-actions
Copy link

github-actions bot commented Apr 1, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1031, delta to last 3 avg.: +1%
  • 😶 query QPS at 15, delta to last 3 avg.: +2%

Breakdown

Version Index QPS Query QPS
current 1031 15
1.1.0 1003 14
1.0.16 1021 14

Backed by latency-tracking. Further commits will update this comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Yongxuanzhang Yongxuanzhang Yongxuanzhang left review comments

@rutujasurve94 rutujasurve94 Awaiting requested review from rutujasurve94

@alanthssss alanthssss Awaiting requested review from alanthssss

Assignees
No one assigned
Labels
area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality component/driver component/resource size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hanxiao @Yongxuanzhang @jina-bot