Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove wrong commit file #2277

Merged
merged 4 commits into from
Apr 2, 2021
Merged

fix: remove wrong commit file #2277

merged 4 commits into from
Apr 2, 2021

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Apr 2, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner April 2, 2021 06:16
bwanglzu
bwanglzu previously approved these changes Apr 2, 2021
Copy link
Member

@bwanglzu bwanglzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Apr 2, 2021

Codecov Report

Merging #2277 (817847e) into master (d9ca73d) will decrease coverage by 36.58%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2277       +/-   ##
===========================================
- Coverage   87.24%   50.66%   -36.59%     
===========================================
  Files         209      209               
  Lines       11416    11416               
===========================================
- Hits         9960     5784     -4176     
- Misses       1456     5632     +4176     
Flag Coverage Δ
daemon 78.01% <ø> (-0.55%) ⬇️
jina 49.26% <100.00%> (-38.43%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/flow/base.py 54.73% <100.00%> (-5.12%) ⬇️
jina/helper.py 55.91% <100.00%> (-27.35%) ⬇️
jina/schemas/pod.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/ping.py 0.00% <0.00%> (-100.00%) ⬇️
jina/schemas/flow.py 0.00% <0.00%> (-100.00%) ⬇️
jina/schemas/meta.py 0.00% <0.00%> (-100.00%) ⬇️
jina/schemas/driver.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/hub/new.py 0.00% <0.00%> (-100.00%) ⬇️
jina/schemas/request.py 0.00% <0.00%> (-100.00%) ⬇️
jina/parsers/hub/list.py 0.00% <0.00%> (-100.00%) ⬇️
... and 137 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 070810d...817847e. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Apr 2, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1024, delta to last 3 avg.: -1%
  • 😶 query QPS at 15, delta to last 3 avg.: -4%

Breakdown

Version Index QPS Query QPS
current 1024 15
1.1.0 1036 15
1.0.16 1052 15

Backed by latency-tracking. Further commits will update this comment.

@jina-bot jina-bot added area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality labels Apr 2, 2021
@jina-bot jina-bot added size/S and removed size/XS labels Apr 2, 2021
@jina-bot jina-bot added size/XS and removed size/S labels Apr 2, 2021
@hanxiao hanxiao merged commit ff2e9a5 into master Apr 2, 2021
@hanxiao hanxiao deleted the chore-rm-test branch April 2, 2021 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants