test(flow): moved test_segmenter.py into a flow unittest

[MiaAltieri]

Flowed the suggestion in #692 to move the tests in test_segmenter.py under flow tests and have the same functionality tested as a simple unittest. Cleaned up some of the duplicated code.

If you'd like to see something else or I've misunderstood please reach out.

[codecov]

Codecov Report

Merging #2287 (d847ebe) into master (03b6f21) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #2287   +/-   ##
=======================================
  Coverage   90.83%   90.83%           
=======================================
  Files         222      222           
  Lines       11740    11740           
=======================================
  Hits        10664    10664           
  Misses       1076     1076           

Flag	Coverage Δ
daemon	51.22% <ø> (ø)
jina	91.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a87e72c...d847ebe. Read the comment docs.

[github-actions]

Latency summary

Current PR yields:

• 😶 index QPS at 1233, delta to last 3 avg.: +0%
• 😶 query QPS at 20, delta to last 3 avg.: -4%

Breakdown

Version	Index QPS	Query QPS
current	1233	20
1.1.5	1242	20
1.1.4	1247	20

Backed by latency-tracking. Further commits will update this comment.

[nan-wang]

Would you please elaborate on the differences between dummy-seg-not-random.yml and dummy-seg-random.yml?

[nan-wang]

recheckcla

[github-actions]

Jina CLA check

❤️ Thank you for your pull request. It looks like this is your first contribution to an open source project maintained by Jina AI Limited. Before we can look at your pull request, we kindly ask that you sign our Contributor License Agreement. You can sign it by commenting in format below.

---

I have read the CLA Document and I hereby sign the CLA

---

[MiaAltieri]

Thank you for taking your time to review my code. My apologies, while adapting the code from its original source underneath tests/integration/mime I didn't check to see if the files dummy-seg-not-random.yml and dummy-seg-random.yml were in fact different. It appears they are the same, let me update the code to reflect that after my evening meeting. Thank you for your patience

[MiaAltieri]

I have read the CLA Document and I hereby sign the CLA

[nan-wang]

LGTM👍

[nan-wang]

@MiaAltieri Thanks for your contribution. However this PR does not pass our docstring and black checks. Please make sure you have the precommit properly set up locally. If you still have the same issue, you will need to either rebase your PR or create a new one.

reference:
https://github.com/jina-ai/jina/blob/master/CONTRIBUTING.md#-making-your-first-submission

[MiaAltieri]

Hi I apologize for committing again without it passing both the docstring check and black. I thought I had done it correctly since black said it passed by reporting the following after I committed:
black....................................................................Passed
Let me look into this more.

If you have any suggestions for things I could check let me know. I noticed that when I looked into the tests that failed on both black and check-dockstring (on git) they both say "Error: The head commit for this pull_request event is not ahead of the base commit. Please submit an issue on this action's GitHub repo." however when I looked at my forked repository it was up to date.

I can try rebasing/creating a new one

[JoanFM]

Hi I apologize for committing again without it passing both the docstring check and black. I thought I had done it correctly since black said it passed by reporting the following after I committed:
black....................................................................Passed
Let me look into this more.

If you have any suggestions for things I could check let me know. I noticed that when I looked into the tests that failed on both black and check-dockstring (on git) they both say "Error: The head commit for this pull_request event is not ahead of the base commit. Please submit an issue on this action's GitHub repo." however when I looked at my forked repository it was up to date.

I can try rebasing/creating a new one

Hey @MiaAltieri , merging with master should be good enough

[MiaAltieri]

Thanks for the tip, rebased into one commit and merged with master