Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scipy version #2293

Merged
merged 1 commit into from Apr 17, 2021
Merged

fix: scipy version #2293

merged 1 commit into from Apr 17, 2021

Conversation

davidbp
Copy link
Contributor

@davidbp davidbp commented Apr 9, 2021

Fix scipy version to a modern one

Fix scipy version to a modern one
@davidbp davidbp requested a review from hanxiao as a code owner April 9, 2021 06:59
@github-actions
Copy link

github-actions bot commented Apr 9, 2021

This PR closes: #1

@jina-bot jina-bot added size/XS area/setup This issue/PR affects setting up Jina labels Apr 9, 2021
@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #2293 (5f7196f) into master (c8fb6b6) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2293   +/-   ##
=======================================
  Coverage   90.42%   90.43%           
=======================================
  Files         211      211           
  Lines       11444    11444           
=======================================
+ Hits        10348    10349    +1     
+ Misses       1096     1095    -1     
Flag Coverage Δ
daemon 51.10% <ø> (ø)
jina 90.88% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/executors/indexers/vector.py 96.63% <0.00%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37a4b71...5f7196f. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Apr 9, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 936, delta to last 3 avg.: -2%
  • 🐢🐢 query QPS at 13, delta to last 3 avg.: -6%

Breakdown

Version Index QPS Query QPS
current 936 13
1.1.2 953 13
1.1.1 966 14

Backed by latency-tracking. Further commits will update this comment.

@nan-wang
Copy link
Member

What's the motivation of update this to a higher version? @davidbp

@davidbp
Copy link
Contributor Author

davidbp commented Apr 11, 2021

What's the motivation of update this to a higher version? @davidbp

Some functions used in Document with sparse arrays do not exist on older versions.

@nan-wang
Copy link
Member

What's the motivation of update this to a higher version? @davidbp

Some functions used in Document with sparse arrays do not exist on older versions.

fair point. What is the minimal version requirement for our needs?

@cristianmtr
Copy link
Contributor

This PR closes: #1

Why did this happen? Not a big deal, but weird

@cristianmtr
Copy link
Contributor

This PR closes: #1

Why did this happen? Not a big deal, but weird

Oh it's because you wrote one in the commit message lol

@hanxiao hanxiao merged commit a8a78a7 into master Apr 17, 2021
@hanxiao hanxiao deleted the fix-scipy-version-1 branch April 17, 2021 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/setup This issue/PR affects setting up Jina size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants