Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rest): expose reload api to rest interface #2301

Merged
merged 1 commit into from
Apr 11, 2021
Merged

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Apr 11, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner April 11, 2021 10:34
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/peapod labels Apr 11, 2021
@codecov
Copy link

codecov bot commented Apr 11, 2021

Codecov Report

Merging #2301 (ca29da0) into master (103bf2f) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2301      +/-   ##
==========================================
+ Coverage   90.33%   90.43%   +0.10%     
==========================================
  Files         211      211              
  Lines       11444    11453       +9     
==========================================
+ Hits        10338    10358      +20     
+ Misses       1106     1095      -11     
Flag Coverage Δ
daemon 51.06% <7.14%> (-0.05%) ⬇️
jina 90.88% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/__init__.py 74.41% <100.00%> (ø)
jina/peapods/runtimes/asyncio/rest/app.py 86.61% <100.00%> (+0.69%) ⬆️
jina/peapods/runtimes/asyncio/rest/models.py 99.20% <100.00%> (+0.01%) ⬆️
jina/peapods/runtimes/zmq/zed.py 93.19% <0.00%> (+1.36%) ⬆️
jina/docker/hubio.py 82.97% <0.00%> (+2.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c6ca3c8...ca29da0. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1015, delta to last 3 avg.: +2%
  • 😶 query QPS at 14, delta to last 3 avg.: -3%

Breakdown

Version Index QPS Query QPS
current 1015 14
1.1.2 987 14

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit d89564d into master Apr 11, 2021
@hanxiao hanxiao deleted the feat-rest-reload branch April 11, 2021 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/peapod size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants