Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dump): type annotations and refactor #2310

Merged
merged 1 commit into from Apr 15, 2021
Merged

Conversation

cristianmtr
Copy link
Contributor

@cristianmtr cristianmtr commented Apr 15, 2021

@theUnkownName Rebase your PSQL PR when this is merged, as it provides better type hints for the dumping

@cristianmtr cristianmtr requested a review from a team as a code owner April 15, 2021 09:35
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase component/executor executor/indexer labels Apr 15, 2021
@codecov
Copy link

codecov bot commented Apr 15, 2021

Codecov Report

Merging #2310 (f0d0aad) into master (8403440) will decrease coverage by 1.64%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2310      +/-   ##
==========================================
- Coverage   90.82%   89.18%   -1.65%     
==========================================
  Files         222      222              
  Lines       11795    11797       +2     
==========================================
- Hits        10713    10521     -192     
- Misses       1082     1276     +194     
Flag Coverage Δ
daemon 51.14% <62.50%> (-0.01%) ⬇️
jina 89.26% <100.00%> (-1.73%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/executors/indexers/dbms/keyvalue.py 97.29% <100.00%> (ø)
jina/executors/indexers/dump.py 98.57% <100.00%> (+0.04%) ⬆️
jina/helloworld/fashion/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
jina/helloworld/multimodal/__init__.py 0.00% <0.00%> (-90.91%) ⬇️
jina/helloworld/helper.py 0.00% <0.00%> (-90.63%) ⬇️
jina/helloworld/chatbot/__init__.py 0.00% <0.00%> (-89.29%) ⬇️
jina/drivers/convert.py 88.88% <0.00%> (-8.34%) ⬇️
jina/executors/devices.py 50.98% <0.00%> (-5.89%) ⬇️
jina/logging/profile.py 92.18% <0.00%> (-3.91%) ⬇️
jina/parsers/helloworld.py 94.64% <0.00%> (-3.58%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8403440...f0d0aad. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 🐎🐎 index QPS at 1188, delta to last 3 avg.: +10%
  • 🐎🐎 query QPS at 17, delta to last 3 avg.: +7%

Breakdown

Version Index QPS Query QPS
current 1188 17
1.1.5 1177 17
1.1.4 964 14

Backed by latency-tracking. Further commits will update this comment.

@cristianmtr cristianmtr merged commit 523747e into master Apr 15, 2021
@cristianmtr cristianmtr deleted the refactor-dump branch April 15, 2021 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants