Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove train as it will be redesigned #2311

Merged
merged 2 commits into from Apr 17, 2021
Merged

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Apr 16, 2021

Changes introduced
In the vision of the design changes to support training in Jina. It is better to clean the code of train features that do not match with roadmap

@codecov
Copy link

codecov bot commented Apr 16, 2021

Codecov Report

Merging #2311 (f7d73c3) into master (523747e) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2311      +/-   ##
==========================================
+ Coverage   90.82%   90.83%   +0.01%     
==========================================
  Files         222      222              
  Lines       11797    11757      -40     
==========================================
- Hits        10715    10680      -35     
+ Misses       1082     1077       -5     
Flag Coverage Δ
daemon 51.21% <100.00%> (+0.06%) ⬆️
jina 91.00% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/executors/compound.py 90.55% <ø> (+0.99%) ⬆️
jina/executors/decorators.py 87.24% <ø> (-0.03%) ⬇️
jina/executors/indexers/__init__.py 97.89% <ø> (ø)
jina/executors/metas.py 96.87% <ø> (ø)
jina/schemas/meta.py 100.00% <ø> (ø)
jina/executors/__init__.py 92.68% <100.00%> (+0.28%) ⬆️
jina/executors/encoders/numeric/__init__.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c3df96...f7d73c3. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Apr 16, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1061, delta to last 3 avg.: +0%
  • 😶 query QPS at 15, delta to last 3 avg.: -4%

Breakdown

Version Index QPS Query QPS
current 1061 15
1.1.5 1054 15
1.1.4 1059 15

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit b840862 into master Apr 17, 2021
@hanxiao hanxiao deleted the remove_train branch April 17, 2021 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants