Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(driver): move dbms to index module #2312

Merged
merged 4 commits into from Apr 18, 2021
Merged

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Apr 18, 2021

also remove the hint of post_init may takes too long as it is too verbose and hurting our principle of "exposing less"

@codecov
Copy link

codecov bot commented Apr 18, 2021

Codecov Report

❗ No coverage uploaded for pull request base (master@1825529). Click here to learn what that means.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2312   +/-   ##
=========================================
  Coverage          ?   90.89%           
=========================================
  Files             ?      221           
  Lines             ?    11786           
  Branches          ?        0           
=========================================
  Hits              ?    10713           
  Misses            ?     1073           
  Partials          ?        0           
Flag Coverage Δ
daemon 50.98% <55.00%> (?)
jina 91.06% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/drivers/index.py 97.95% <100.00%> (ø)
jina/executors/__init__.py 92.65% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1825529...7dba2be. Read the comment docs.

@jina-bot jina-bot added the area/testing This issue/PR affects testing label Apr 18, 2021
@github-actions
Copy link

github-actions bot commented Apr 18, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 941, delta to last 3 avg.: +0%
  • 🐢🐢 query QPS at 13, delta to last 3 avg.: -6%

Breakdown

Version Index QPS Query QPS
current 941 13
1.1.5 943 13
1.1.4 946 14

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 4375be5 into master Apr 18, 2021
@hanxiao hanxiao deleted the move-dbms-driver branch April 18, 2021 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/driver component/executor executor/meta size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants