Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add enums to control embedding types #2318

Merged
merged 1 commit into from
Apr 20, 2021
Merged

feat: add enums to control embedding types #2318

merged 1 commit into from
Apr 20, 2021

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Apr 20, 2021

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner April 20, 2021 08:02
@jina-bot jina-bot added size/M area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/testing This issue/PR affects testing component/driver component/type labels Apr 20, 2021
@codecov
Copy link

codecov bot commented Apr 20, 2021

Codecov Report

Merging #2318 (e6deb86) into master (816e183) will increase coverage by 0.02%.
The diff coverage is 96.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2318      +/-   ##
==========================================
+ Coverage   90.92%   90.94%   +0.02%     
==========================================
  Files         222      222              
  Lines       11792    11819      +27     
==========================================
+ Hits        10722    10749      +27     
  Misses       1070     1070              
Flag Coverage Δ
daemon 51.15% <52.83%> (+0.09%) ⬆️
jina 91.12% <96.22%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/types/sets/document.py 94.25% <81.81%> (-1.07%) ⬇️
jina/__init__.py 74.71% <100.00%> (ø)
jina/drivers/index.py 97.82% <100.00%> (-0.14%) ⬇️
jina/drivers/search.py 98.70% <100.00%> (-0.05%) ⬇️
jina/enums.py 96.00% <100.00%> (+0.82%) ⬆️
jina/drivers/querylang/select.py 89.65% <0.00%> (+6.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43f382f...e6deb86. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Apr 20, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 963, delta to last 3 avg.: -1%
  • 😶 query QPS at 14, delta to last 3 avg.: -4%

Breakdown

Version Index QPS Query QPS
current 963 14
1.1.7 978 14

Backed by latency-tracking. Further commits will update this comment.

@davidbp
Copy link
Contributor

davidbp commented Apr 20, 2021

LGTM, even though I'm not sure BetterEnum is a needed input to the class EmbeddingClsType(BetterEnum)

@JoanFM JoanFM requested a review from davidbp April 20, 2021 08:54
@JoanFM
Copy link
Member Author

JoanFM commented Apr 20, 2021

LGTM, even though I'm not sure BetterEnum is a needed input to the class EmbeddingClsType(BetterEnum)

Then, can u approve?

@JoanFM JoanFM merged commit f10709d into master Apr 20, 2021
@JoanFM JoanFM deleted the sparse-enums branch April 20, 2021 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/testing This issue/PR affects testing component/driver component/type size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants