Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(driver): replace annotation check with typing module #2327

Merged
merged 4 commits into from
Apr 21, 2021

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Apr 21, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner April 21, 2021 09:56
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/driver labels Apr 21, 2021
@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #2327 (634cc34) into master (ddedd44) will decrease coverage by 0.00%.
The diff coverage is 92.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2327      +/-   ##
==========================================
- Coverage   90.94%   90.93%   -0.01%     
==========================================
  Files         222      222              
  Lines       11793    11831      +38     
==========================================
+ Hits        10725    10759      +34     
- Misses       1068     1072       +4     
Flag Coverage Δ
daemon 51.14% <44.28%> (+0.08%) ⬆️
jina 91.11% <92.85%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/helloworld/chatbot/__init__.py 89.28% <ø> (-1.63%) ⬇️
jina/types/sets/document.py 94.25% <81.81%> (-1.07%) ⬇️
jina/drivers/__init__.py 90.12% <83.33%> (-0.63%) ⬇️
jina/drivers/index.py 97.82% <100.00%> (-0.14%) ⬇️
jina/drivers/search.py 98.70% <100.00%> (-0.05%) ⬇️
jina/enums.py 96.00% <100.00%> (+0.82%) ⬆️
jina/docker/hubapi/local.py 90.10% <0.00%> (+1.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e67393...634cc34. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Apr 21, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 967, delta to last 3 avg.: +0%
  • 🐢🐢 query QPS at 13, delta to last 3 avg.: -6%

Breakdown

Version Index QPS Query QPS
current 967 13
1.1.7 960 13

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 2fa264d into master Apr 21, 2021
@hanxiao hanxiao deleted the fix-type-annot branch April 21, 2021 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/driver size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants