Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep old crafter and segmenter functionality #2351

Merged
merged 2 commits into from
Apr 26, 2021
Merged

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Apr 26, 2021

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner April 26, 2021 12:10
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase component/driver labels Apr 26, 2021
@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #2351 (8602486) into master (9cb2330) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2351   +/-   ##
=======================================
  Coverage   90.86%   90.87%           
=======================================
  Files         222      222           
  Lines       12013    12019    +6     
=======================================
+ Hits        10916    10922    +6     
  Misses       1097     1097           
Flag Coverage Δ
daemon 50.77% <50.00%> (-0.01%) ⬇️
jina 91.03% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/drivers/__init__.py 90.20% <100.00%> (+0.08%) ⬆️
jina/drivers/craft.py 100.00% <100.00%> (ø)
jina/drivers/segment.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cb2330...8602486. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Apr 26, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 971, delta to last 3 avg.: +1%
  • 😶 query QPS at 14, delta to last 3 avg.: +1%

Breakdown

Version Index QPS Query QPS
current 971 14
1.1.10 956 13
1.1.9 961 14

Backed by latency-tracking. Further commits will update this comment.

@jina-bot jina-bot added the area/testing This issue/PR affects testing label Apr 26, 2021
@JoanFM JoanFM merged commit 38d8c32 into master Apr 26, 2021
@JoanFM JoanFM deleted the remove-sniffing branch April 26, 2021 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/driver size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants