Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid flush when kbinterrupt #2353

Merged
merged 2 commits into from
Apr 27, 2021
Merged

fix: avoid flush when kbinterrupt #2353

merged 2 commits into from
Apr 27, 2021

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Apr 26, 2021

Related to #2352 and #2343

@JoanFM JoanFM requested a review from a team as a code owner April 26, 2021 14:58
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality component/peapod labels Apr 26, 2021
@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #2353 (d991a24) into master (f4d0893) will increase coverage by 2.49%.
The diff coverage is 70.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2353      +/-   ##
==========================================
+ Coverage   88.35%   90.84%   +2.49%     
==========================================
  Files         223      223              
  Lines       12021    12026       +5     
==========================================
+ Hits        10621    10925     +304     
+ Misses       1400     1101     -299     
Flag Coverage Δ
daemon 50.78% <50.00%> (-0.02%) ⬇️
jina 91.00% <70.00%> (+2.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/peapods/runtimes/zmq/zed.py 91.39% <40.00%> (-1.81%) ⬇️
jina/peapods/zmq/__init__.py 79.82% <100.00%> (+0.65%) ⬆️
jina/enums.py 96.00% <0.00%> (+0.57%) ⬆️
jina/executors/compound.py 83.16% <0.00%> (+1.98%) ⬆️
jina/jaml/helper.py 93.89% <0.00%> (+2.29%) ⬆️
jina/drivers/control.py 89.41% <0.00%> (+2.35%) ⬆️
jina/jaml/__init__.py 96.37% <0.00%> (+4.14%) ⬆️
jina/types/request/__init__.py 99.23% <0.00%> (+6.15%) ⬆️
jina/parsers/helper.py 42.38% <0.00%> (+6.62%) ⬆️
... and 18 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4d0893...d991a24. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1028, delta to last 3 avg.: +0%
  • 😶 query QPS at 15, delta to last 3 avg.: -2%

Breakdown

Version Index QPS Query QPS
current 1028 15
1.1.10 1039 15
1.1.9 1018 15

Backed by latency-tracking. Further commits will update this comment.

Copy link
Member

@nan-wang nan-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@JoanFM JoanFM merged commit 3a54b8d into master Apr 27, 2021
@JoanFM JoanFM deleted the fix-kbinterrupt branch April 27, 2021 06:25
davidbp pushed a commit that referenced this pull request Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality component/peapod size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants