-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(hubio): when error occurs, exit code should be set to non-zero #2871
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2871 +/- ##
==========================================
+ Coverage 82.21% 88.82% +6.60%
==========================================
Files 106 138 +32
Lines 7064 9515 +2451
==========================================
+ Hits 5808 8452 +2644
+ Misses 1256 1063 -193
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hub test is broken
13a2085
to
9a27a67
Compare
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to clarify, this line assumes that push
is always used under CLI, and it will invalidate the usage from other Python functions.
Fix that when error occurs, the exit code still be 0. It makes tests confusing and hard to detect whether it's successful or not.