feat(logging): skip unnecessary log message constructions #2886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jina-bot
added
size/S
area/core
Codecov Report
@@ Coverage Diff @@
## master #2886 +/- ##
==========================================
+ Coverage 88.07% 88.15% +0.07%
==========================================
Files 138 138
Lines 9505 9508 +3
==========================================
+ Hits 8372 8382 +10
+ Misses 1133 1126 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
JoanFM
previously approved these changes
Jul 8, 2021
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
jacobowitz
force-pushed
the
feat-speed-up-logging
branch
from
cb88b60
to
c0f73c1
Compare
JoanFM
approved these changes
Jul 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When processing data requests (which is a quite frequent task) we construct some log messages in every case for debug logging purpose. This happens even when debug logging is disabled. I think that is wasteful and should be avoided.
The easiest way to avoid this is to check for the log level and only construct the log message if necessary. This is also recommended in the Python documentation.
The idea for this came up in this pr: #2865
I only changed it for a few cases in this PR which happen quite often and should inflict the most costs for us. Other cases (Initialization and control messages) should not happen often enough that its worth to introduce this check there, I think.