Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix override with with parallel #2890

Merged
merged 1 commit into from
Jul 8, 2021
Merged

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Jul 8, 2021

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner July 8, 2021 11:01
@JoanFM JoanFM linked an issue Jul 8, 2021 that may be closed by this pull request
@jina-bot jina-bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/executor executor/meta labels Jul 8, 2021
@codecov
Copy link

codecov bot commented Jul 8, 2021

Codecov Report

Merging #2890 (ac4f833) into master (2fd414b) will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2890      +/-   ##
==========================================
- Coverage   88.10%   88.04%   -0.06%     
==========================================
  Files         138      138              
  Lines        9505     9505              
==========================================
- Hits         8374     8369       -5     
- Misses       1131     1136       +5     
Flag Coverage Δ
daemon 43.41% <ø> (ø)
jina 87.99% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/executors/__init__.py 82.47% <ø> (ø)
jina/peapods/peas/__init__.py 95.88% <0.00%> (-2.36%) ⬇️
jina/peapods/pods/compound.py 90.14% <0.00%> (-1.41%) ⬇️
jina/jaml/parsers/executor/legacy.py 93.44% <0.00%> (+1.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2fd414b...ac4f833. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jul 8, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1534, delta to last 1 avg.: +2%
  • 🐎🐎 query QPS at 27, delta to last 1 avg.: +6%
  • 🐎🐎 import jina within 0.2425s, delta to last 1 avg.: +8%

Breakdown

Version Index QPS Query QPS Import Time (s)
current 1534 27 0.2425
2.0.4 1493 25 0.2236

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM merged commit 4168048 into master Jul 8, 2021
@JoanFM JoanFM deleted the fix-override-parallel branch July 8, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/executor executor/meta size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing extra init parameters to executors does not work when parallel>1
3 participants