Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(hub): alias to name #3335

Merged
merged 1 commit into from Sep 3, 2021
Merged

refactor(hub): alias to name #3335

merged 1 commit into from Sep 3, 2021

Conversation

mapleeit
Copy link
Member

@mapleeit mapleeit commented Sep 3, 2021

No description provided.

@mapleeit mapleeit requested a review from a team as a code owner September 3, 2021 02:47
@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing labels Sep 3, 2021
@codecov
Copy link

codecov bot commented Sep 3, 2021

Codecov Report

Merging #3335 (04d177c) into master (f76326d) will increase coverage by 0.97%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3335      +/-   ##
==========================================
+ Coverage   88.75%   89.73%   +0.97%     
==========================================
  Files         152      152              
  Lines       10810    10809       -1     
==========================================
+ Hits         9594     9699     +105     
+ Misses       1216     1110     -106     
Flag Coverage Δ
daemon 45.66% <20.00%> (-0.02%) ⬇️
jina 89.72% <80.00%> (+1.42%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/hubble/hubio.py 88.13% <75.00%> (-0.05%) ⬇️
jina/hubble/__init__.py 100.00% <100.00%> (ø)
jina/peapods/peas/__init__.py 86.45% <0.00%> (+0.64%) ⬆️
jina/peapods/zmq/__init__.py 89.04% <0.00%> (+0.69%) ⬆️
jina/peapods/runtimes/zmq/zed.py 93.87% <0.00%> (+1.02%) ⬆️
jina/peapods/runtimes/gateway/http/app.py 92.40% <0.00%> (+1.26%) ⬆️
jina/types/message/__init__.py 87.37% <0.00%> (+1.45%) ⬆️
jina/jaml/parsers/flow/v1.py 98.24% <0.00%> (+1.75%) ⬆️
jina/peapods/runtimes/zmq/asyncio.py 96.36% <0.00%> (+1.81%) ⬆️
jina/jaml/helper.py 85.36% <0.00%> (+2.43%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7415821...04d177c. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Sep 3, 2021

Latency summary

Current PR yields:

  • 🐎🐎🐎🐎 index QPS at 1178, delta to last 2 avg.: +13%
  • 🐎🐎 query QPS at 46, delta to last 2 avg.: +10%
  • 🐎🐎 dam extend QPS at 45510, delta to last 2 avg.: +12%
  • 🐎🐎 avg flow time within 1.5174 seconds, delta to last 2 avg.: +0%
  • 😶 import jina within 0.4113 seconds, delta to last 2 avg.: -3%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1178 46 45510 1.5174 0.4113
2.0.23 1027 40 39496 1.5837 0.4286
2.0.22 1055 42 41211 1.4593 0.4217

Backed by latency-tracking. Further commits will update this comment.

@mapleeit mapleeit changed the title fix(hub): alias to name refactor(hub): alias to name Sep 3, 2021
@hanxiao hanxiao merged commit 40416c2 into master Sep 3, 2021
@hanxiao hanxiao deleted the alias-to-name branch September 3, 2021 06:18
deepankarm pushed a commit that referenced this pull request Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants