Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add api for pod args #335

Merged
merged 2 commits into from
Apr 27, 2020
Merged

feat: add api for pod args #335

merged 2 commits into from
Apr 27, 2020

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Apr 27, 2020

very first version of the pod api export, available at /data/api/pod (logserver.default.yml)

It returns {'pod': d, 'version': jina_version, 'usage': pod_cli_usage}, where d is the 'help', 'choices', 'default' and 'type' of each arg.

Limits:

  • enum is stringify to int and becomes 0,1,2... semantics are lost
  • default is only for reference, as some random default args will give random value everytime you call it.

@jina-bot
Copy link
Member

jina-bot commented Apr 27, 2020

Jina CLA check ✅ All Contributors have signed the CLA.

@jina-bot jina-bot added size/M area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs area/helper This issue/PR affects the helper functionality component/entrypoint component/logging component/resource labels Apr 27, 2020
@hanxiao hanxiao merged commit a26a208 into master Apr 27, 2020
@hanxiao hanxiao deleted the feat-podapi-endpoint branch April 27, 2020 12:19
@jina-ai jina-ai locked and limited conversation to collaborators Apr 27, 2020
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs area/helper This issue/PR affects the helper functionality component/entrypoint component/logging component/resource size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants