Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(helper): fix spinner timer update #3436

Merged
merged 3 commits into from
Sep 19, 2021
Merged

fix(helper): fix spinner timer update #3436

merged 3 commits into from
Sep 19, 2021

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Sep 19, 2021

No description provided.

@hanxiao hanxiao requested a review from a team as a code owner September 19, 2021 07:41
@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase component/logging labels Sep 19, 2021
@codecov
Copy link

codecov bot commented Sep 19, 2021

Codecov Report

Merging #3436 (9f0a90f) into master (053cc52) will increase coverage by 0.07%.
The diff coverage is 97.22%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3436      +/-   ##
==========================================
+ Coverage   90.19%   90.27%   +0.07%     
==========================================
  Files         152      152              
  Lines       10954    10971      +17     
==========================================
+ Hits         9880     9904      +24     
+ Misses       1074     1067       -7     
Flag Coverage Δ
daemon 45.62% <30.55%> (-0.02%) ⬇️
jina 90.26% <97.22%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/flow/base.py 89.94% <66.66%> (ø)
jina/enums.py 96.17% <100.00%> (+0.10%) ⬆️
jina/helper.py 82.97% <100.00%> (-0.37%) ⬇️
jina/logging/profile.py 98.76% <100.00%> (+2.76%) ⬆️
jina/peapods/runtimes/base.py 87.09% <100.00%> (ø)
jina/clients/base/__init__.py 92.42% <0.00%> (+1.51%) ⬆️
jina/importer.py 87.17% <0.00%> (+2.56%) ⬆️
jina/clients/base/websocket.py 90.90% <0.00%> (+4.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1616d56...9f0a90f. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Sep 19, 2021

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1220, delta to last 2 avg.: -10%
  • 🐢🐢 query QPS at 51, delta to last 2 avg.: -10%
  • 🐢🐢 dam extend QPS at 49800, delta to last 2 avg.: -5%
  • 🐢🐢 avg flow time within 1.1408 seconds, delta to last 2 avg.: -24%
  • 🐎🐎 import jina within 0.4243 seconds, delta to last 2 avg.: +9%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1220 51 49800 1.1408 0.4243
2.1.1 1443 60 59080 1.3066 0.3332
2.1.0 1294 53 46279 1.7219 0.4446

Backed by latency-tracking. Further commits will update this comment.

@github-actions github-actions bot added size/M area/helper This issue/PR affects the helper functionality area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/peapod and removed size/S labels Sep 19, 2021
@hanxiao hanxiao merged commit 1d214f7 into master Sep 19, 2021
@hanxiao hanxiao deleted the fix-spinner-timer branch September 19, 2021 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/flow component/logging component/peapod size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant