Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(kubernetes): add kubernetes dep to perf #3542

Merged
merged 2 commits into from
Oct 1, 2021

Conversation

jacobowitz
Copy link
Contributor

@jacobowitz jacobowitz commented Oct 1, 2021

fixes #3536

Perf is needed so that the requirement is actually part of all hubble built docker images.

@jacobowitz jacobowitz requested a review from JoanFM October 1, 2021 07:23
@github-actions github-actions bot added size/XS area/setup This issue/PR affects setting up Jina labels Oct 1, 2021
JoanFM
JoanFM previously approved these changes Oct 1, 2021
Copy link
Member

@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a big fan of this solution but it is needed

@github-actions
Copy link

github-actions bot commented Oct 1, 2021

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1034, delta to last 2 avg.: -9%
  • 😶 query QPS at 46, delta to last 2 avg.: -5%
  • 😶 dam extend QPS at 39064, delta to last 2 avg.: -9%
  • 😶 avg flow time within 1.2136 seconds, delta to last 2 avg.: -29%
  • 🐎🐎🐎🐎 import jina within 0.4574 seconds, delta to last 2 avg.: +11%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1034 46 39064 1.2136 0.4574
2.1.5 1089 50 41023 1.7148 0.4289
2.1.4 1195 47 45095 1.7137 0.3897

Backed by latency-tracking. Further commits will update this comment.

@jacobowitz jacobowitz closed this Oct 1, 2021
@jacobowitz jacobowitz reopened this Oct 1, 2021
@github-actions github-actions bot added area/core This issue/PR affects the core codebase component/resource labels Oct 1, 2021
@codecov
Copy link

codecov bot commented Oct 1, 2021

Codecov Report

Merging #3542 (2931176) into master (4286a86) will increase coverage by 2.40%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3542      +/-   ##
==========================================
+ Coverage   86.90%   89.31%   +2.40%     
==========================================
  Files         152      152              
  Lines       11305    11310       +5     
==========================================
+ Hits         9825    10101     +276     
+ Misses       1480     1209     -271     
Flag Coverage Δ
daemon 45.49% <15.38%> (-0.02%) ⬇️
jina 89.24% <100.00%> (+2.86%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/__init__.py 71.25% <100.00%> (ø)
jina/peapods/pods/k8s.py 75.00% <100.00%> (+0.64%) ⬆️
jina/types/arrays/memmap.py 95.04% <100.00%> (+0.01%) ⬆️
jina/peapods/peas/__init__.py 85.89% <0.00%> (-4.49%) ⬇️
jina/peapods/runtimes/jinad/__init__.py 88.88% <0.00%> (-3.71%) ⬇️
jina/peapods/pods/compound.py 82.71% <0.00%> (-1.24%) ⬇️
jina/peapods/runtimes/zmq/zed.py 93.87% <0.00%> (+0.51%) ⬆️
jina/peapods/zmq/__init__.py 89.51% <0.00%> (+0.93%) ⬆️
jina/peapods/runtimes/gateway/http/app.py 92.40% <0.00%> (+1.26%) ⬆️
jina/types/message/__init__.py 87.37% <0.00%> (+1.45%) ⬆️
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4abdc0d...2931176. Read the comment docs.

@JoanFM JoanFM merged commit 9d758a0 into master Oct 1, 2021
@JoanFM JoanFM deleted the fix-kubernetes-hubble-requirement branch October 1, 2021 08:51
hanxiao added a commit that referenced this pull request Oct 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/setup This issue/PR affects setting up Jina component/resource size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kubernetes dependency not installed in Executor images
4 participants