Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix cla #3575

Merged
merged 1 commit into from
Oct 5, 2021
Merged

ci: fix cla #3575

merged 1 commit into from
Oct 5, 2021

Conversation

nan-wang
Copy link
Member

@nan-wang nan-wang commented Oct 5, 2021

Instead of using our fork, this pr switches to the latest upstream version at https://github.com/cla-assistant/github-action

@nan-wang nan-wang requested a review from hanxiao as a code owner October 5, 2021 02:22
@github-actions
Copy link

github-actions bot commented Oct 5, 2021

This PR closes: #1

@github-actions github-actions bot added size/S area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Oct 5, 2021
@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #3575 (28833ba) into master (4286a86) will increase coverage by 0.67%.
The diff coverage is 96.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3575      +/-   ##
==========================================
+ Coverage   86.90%   87.58%   +0.67%     
==========================================
  Files         152      152              
  Lines       11305    11325      +20     
==========================================
+ Hits         9825     9919      +94     
+ Misses       1480     1406      -74     
Flag Coverage Δ
daemon 40.36% <40.00%> (-5.15%) ⬇️
jina 87.53% <96.66%> (+1.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/types/arrays/document.py 85.44% <91.66%> (+0.23%) ⬆️
jina/__init__.py 71.25% <100.00%> (ø)
jina/peapods/pods/k8s.py 75.00% <100.00%> (+0.64%) ⬆️
jina/types/arrays/memmap.py 95.09% <100.00%> (+0.06%) ⬆️
jina/clients/helper.py 50.00% <0.00%> (-50.00%) ⬇️
jina/importer.py 57.69% <0.00%> (-29.49%) ⬇️
jina/helper.py 66.60% <0.00%> (-16.52%) ⬇️
jina/types/request/__init__.py 85.34% <0.00%> (-13.80%) ⬇️
jina/checker.py 86.20% <0.00%> (-10.35%) ⬇️
jina/logging/profile.py 90.36% <0.00%> (-7.84%) ⬇️
... and 27 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6bac8fc...28833ba. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Oct 5, 2021

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1104, delta to last 2 avg.: -20%
  • 🐢🐢 query QPS at 49, delta to last 2 avg.: -17%
  • 🐢🐢 dam extend QPS at 36732, delta to last 2 avg.: -35%
  • 🐢🐢 avg flow time within 1.718 seconds, delta to last 2 avg.: +36%
  • 🐎🐎🐎🐎 import jina within 0.4362 seconds, delta to last 2 avg.: +15%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1104 49 36732 1.718 0.4362
2.1.5 1577 67 63289 1.3861 0.3454
2.1.4 1210 50 50363 1.1371 0.4098

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM merged commit ce1f422 into master Oct 5, 2021
@JoanFM JoanFM deleted the ci-fix-cla-1 branch October 5, 2021 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants