Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: try to return results #3581

Merged
merged 1 commit into from
Oct 5, 2021
Merged

test: try to return results #3581

merged 1 commit into from
Oct 5, 2021

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Oct 5, 2021

No description provided.

@JoanFM JoanFM requested a review from a team as a code owner October 5, 2021 09:52
@github-actions github-actions bot added size/S area/testing This issue/PR affects testing labels Oct 5, 2021
@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #3581 (f726135) into master (c77ed13) will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3581      +/-   ##
==========================================
+ Coverage   89.34%   89.42%   +0.07%     
==========================================
  Files         152      152              
  Lines       11460    11460              
==========================================
+ Hits        10239    10248       +9     
+ Misses       1221     1212       -9     
Flag Coverage Δ
daemon 45.19% <ø> (ø)
jina 88.64% <ø> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/peapods/pods/k8slib/kubernetes_tools.py 89.77% <0.00%> (-1.14%) ⬇️
jina/flow/base.py 92.34% <0.00%> (+1.36%) ⬆️
jina/peapods/runtimes/jinad/__init__.py 90.74% <0.00%> (+1.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c77ed13...f726135. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Oct 5, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1093, delta to last 2 avg.: -5%
  • 😶 query QPS at 48, delta to last 2 avg.: -4%
  • 😶 dam extend QPS at 39115, delta to last 2 avg.: -13%
  • 😶 avg flow time within 1.1962 seconds, delta to last 2 avg.: -8%
  • 🐎🐎🐎🐎 import jina within 0.4918 seconds, delta to last 2 avg.: +16%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1093 48 39115 1.1962 0.4918
2.1.5 1152 50 41137 1.1839 0.4259
2.1.4 1161 49 49080 1.4181 0.4157

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM merged commit f7e306a into master Oct 5, 2021
@JoanFM JoanFM deleted the on_done_tests_remove branch October 5, 2021 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing This issue/PR affects testing size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants