Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scipy sparse import #3583

Merged
merged 1 commit into from
Oct 6, 2021
Merged

fix: scipy sparse import #3583

merged 1 commit into from
Oct 6, 2021

Conversation

cristianmtr
Copy link
Contributor

@cristianmtr cristianmtr requested a review from a team as a code owner October 5, 2021 12:51
@github-actions github-actions bot added size/XS area/core This issue/PR affects the core codebase component/type labels Oct 5, 2021
@codecov
Copy link

codecov bot commented Oct 5, 2021

Codecov Report

Merging #3583 (e671564) into master (abd8e6c) will decrease coverage by 0.41%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3583      +/-   ##
==========================================
- Coverage   89.19%   88.77%   -0.42%     
==========================================
  Files         151      152       +1     
  Lines       11243    11461     +218     
==========================================
+ Hits        10028    10175     +147     
- Misses       1215     1286      +71     
Flag Coverage Δ
daemon 45.18% <ø> (-0.32%) ⬇️
jina 88.71% <ø> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/types/document/__init__.py 96.07% <ø> (+<0.01%) ⬆️
jina/peapods/pods/k8s.py 60.92% <0.00%> (-31.08%) ⬇️
jina/peapods/pods/k8slib/kubernetes_tools.py 72.72% <0.00%> (-6.99%) ⬇️
jina/peapods/pods/compound.py 83.95% <0.00%> (-6.40%) ⬇️
jina/types/arrays/abstract.py 65.38% <0.00%> (-3.59%) ⬇️
jina/peapods/runtimes/container/__init__.py 80.12% <0.00%> (-1.75%) ⬇️
jina/hubble/hubapi.py 96.00% <0.00%> (-0.94%) ⬇️
jina/flow/base.py 87.92% <0.00%> (-0.33%) ⬇️
jina/peapods/runtimes/jinad/__init__.py 88.88% <0.00%> (ø)
jina/parsers/hubble/new.py 100.00% <0.00%> (ø)
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abd8e6c...e671564. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Oct 5, 2021

Latency summary

Current PR yields:

  • 🐎🐎 index QPS at 1303, delta to last 2 avg.: +10%
  • 🐎🐎 query QPS at 55, delta to last 2 avg.: +10%
  • 🐎🐎 dam extend QPS at 47552, delta to last 2 avg.: +8%
  • 🐎🐎 avg flow time within 1.694 seconds, delta to last 2 avg.: +8%
  • 🐢🐢 import jina within 0.3466 seconds, delta to last 2 avg.: -16%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1303 55 47552 1.694 0.3466
2.1.5 1146 50 43711 1.6949 0.4162
2.1.4 1213 49 43987 1.4239 0.416

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM merged commit 3ac2603 into master Oct 6, 2021
@JoanFM JoanFM deleted the fix-scipy-sparse branch October 6, 2021 09:40
gauthamsuresh09 pushed a commit to gauthamsuresh09/jina that referenced this pull request Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase component/type size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants