Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add link to flow parallelization #3597

Merged
merged 2 commits into from
Oct 7, 2021
Merged

Conversation

cristianmtr
Copy link
Contributor

No description provided.

Copy link
Member

@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will add this after PR #3535 is merged, and the concepts are aligned and clarified

@github-actions github-actions bot added size/S area/docs This issue/PR affects the docs labels Oct 6, 2021
@github-actions
Copy link

github-actions bot commented Oct 6, 2021

Latency summary

Current PR yields:

  • 🐎🐎🐎🐎 index QPS at 1429, delta to last 2 avg.: +14%
  • 🐎🐎🐎🐎 query QPS at 63, delta to last 2 avg.: +21%
  • 🐎🐎🐎🐎 dam extend QPS at 56308, delta to last 2 avg.: +34%
  • 🐎🐎🐎🐎 avg flow time within 1.3759 seconds, delta to last 2 avg.: -18%
  • 🐢🐢 import jina within 0.3488 seconds, delta to last 2 avg.: -8%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1429 63 56308 1.3759 0.3488
2.1.5 1349 57 42902 1.6913 0.3508
2.1.4 1137 45 40752 1.6874 0.4117

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #3597 (74aa5ea) into master (abd8e6c) will decrease coverage by 0.52%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3597      +/-   ##
==========================================
- Coverage   89.19%   88.67%   -0.53%     
==========================================
  Files         151      154       +3     
  Lines       11243    11527     +284     
==========================================
+ Hits        10028    10221     +193     
- Misses       1215     1306      +91     
Flag Coverage Δ
daemon 45.08% <ø> (-0.42%) ⬇️
jina 88.60% <ø> (-0.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/peapods/pods/k8s.py 60.92% <0.00%> (-31.08%) ⬇️
jina/peapods/pods/compound.py 82.71% <0.00%> (-7.63%) ⬇️
jina/peapods/pods/k8slib/kubernetes_tools.py 72.72% <0.00%> (-6.99%) ⬇️
jina/peapods/runtimes/gateway/websocket/app.py 85.41% <0.00%> (-3.72%) ⬇️
jina/types/arrays/abstract.py 65.38% <0.00%> (-3.59%) ⬇️
jina/peapods/runtimes/container/__init__.py 80.12% <0.00%> (-1.75%) ⬇️
jina/hubble/hubapi.py 96.00% <0.00%> (-0.94%) ⬇️
jina/helper.py 82.76% <0.00%> (-0.36%) ⬇️
jina/flow/base.py 87.92% <0.00%> (-0.33%) ⬇️
jina/peapods/runtimes/gateway/prefetch.py
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abd8e6c...74aa5ea. Read the comment docs.

@JoanFM JoanFM merged commit 632f061 into master Oct 7, 2021
@JoanFM JoanFM deleted the docs-link-flow-parallelization branch October 7, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs This issue/PR affects the docs size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants