Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: k8s credentials #3602

Merged
merged 1 commit into from
Oct 7, 2021
Merged

docs: k8s credentials #3602

merged 1 commit into from
Oct 7, 2021

Conversation

florian-hoenicke
Copy link
Member

As discovered by @cristianmtr there is a manual extra-step involved when running the test. The password has to be inserted manually into the script.
This hands over the password via environment variable.

@github-actions github-actions bot added size/XS area/docs This issue/PR affects the docs labels Oct 7, 2021
@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #3602 (c038ccb) into master (add58f5) will decrease coverage by 0.12%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3602      +/-   ##
==========================================
- Coverage   89.55%   89.42%   -0.13%     
==========================================
  Files         154      154              
  Lines       11542    11542              
==========================================
- Hits        10337    10322      -15     
- Misses       1205     1220      +15     
Flag Coverage Δ
daemon 45.09% <ø> (+0.01%) ⬆️
jina 88.64% <ø> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/peapods/peas/__init__.py 85.89% <0.00%> (-4.49%) ⬇️
jina/peapods/runtimes/jinad/__init__.py 87.96% <0.00%> (-3.71%) ⬇️
jina/clients/base/http.py 96.49% <0.00%> (-1.76%) ⬇️
jina/peapods/pods/k8s.py 78.57% <0.00%> (-1.69%) ⬇️
jina/peapods/pods/compound.py 82.71% <0.00%> (-1.24%) ⬇️
jina/peapods/pods/k8slib/kubernetes_tools.py 90.69% <0.00%> (-1.17%) ⬇️
jina/helper.py 82.76% <0.00%> (-0.36%) ⬇️
jina/clients/base/__init__.py 92.42% <0.00%> (+1.51%) ⬆️
jina/peapods/runtimes/container/__init__.py 81.92% <0.00%> (+1.80%) ⬆️
jina/importer.py 87.17% <0.00%> (+2.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df24dce...c038ccb. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1241, delta to last 2 avg.: -13%
  • 🐢🐢 query QPS at 54, delta to last 2 avg.: -12%
  • 🐢🐢 dam extend QPS at 42856, delta to last 2 avg.: -25%
  • 🐢🐢 avg flow time within 1.7001 seconds, delta to last 2 avg.: +25%
  • 🐎🐎🐎🐎 import jina within 0.4854 seconds, delta to last 2 avg.: +34%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1241 54 42856 1.7001 0.4854
2.1.5 1440 63 56211 1.3144 0.3664
2.1.4 1442 60 59262 1.3938 0.3572

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM merged commit 1b62185 into master Oct 7, 2021
@JoanFM JoanFM deleted the docs-k8s-credentials branch October 7, 2021 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs This issue/PR affects the docs size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants