Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added more progress bar options #3605

Merged
merged 1 commit into from
Oct 7, 2021
Merged

Conversation

maximilianwerk
Copy link
Member

This allows overwriting a progressbar with another progressbar. Sometimes this comes handy.

@maximilianwerk maximilianwerk requested a review from a team as a code owner October 7, 2021 11:46
@github-actions github-actions bot added size/XS area/core This issue/PR affects the core codebase component/logging labels Oct 7, 2021
JoanFM
JoanFM previously approved these changes Oct 7, 2021
@codecov
Copy link

codecov bot commented Oct 7, 2021

Codecov Report

Merging #3605 (f10c24a) into master (add58f5) will decrease coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3605      +/-   ##
==========================================
- Coverage   89.55%   89.50%   -0.06%     
==========================================
  Files         154      154              
  Lines       11542    11544       +2     
==========================================
- Hits        10337    10333       -4     
- Misses       1205     1211       +6     
Flag Coverage Δ
daemon 45.07% <0.00%> (-0.01%) ⬇️
jina 88.72% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/logging/profile.py 98.21% <100.00%> (+0.02%) ⬆️
jina/peapods/runtimes/jinad/__init__.py 89.81% <0.00%> (-1.86%) ⬇️
jina/clients/base/http.py 96.49% <0.00%> (-1.76%) ⬇️
jina/peapods/pods/k8s.py 78.57% <0.00%> (-1.69%) ⬇️
jina/peapods/pods/k8slib/kubernetes_tools.py 90.69% <0.00%> (-1.17%) ⬇️
jina/helper.py 82.76% <0.00%> (-0.36%) ⬇️
jina/peapods/runtimes/zmq/zed.py 94.38% <0.00%> (+0.51%) ⬆️
jina/clients/base/__init__.py 92.42% <0.00%> (+1.51%) ⬆️
jina/importer.py 87.17% <0.00%> (+2.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df24dce...f10c24a. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Oct 7, 2021

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1099, delta to last 2 avg.: -18%
  • 🐢🐢 query QPS at 48, delta to last 2 avg.: -16%
  • 🐢🐢 dam extend QPS at 40359, delta to last 2 avg.: -26%
  • 🐢🐢 avg flow time within 1.1942 seconds, delta to last 2 avg.: +7%
  • 🐎🐎🐎🐎 import jina within 0.5104 seconds, delta to last 2 avg.: +18%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1099 48 40359 1.1942 0.5104
2.1.5 1245 54 49399 1.1449 0.5029
2.1.4 1443 60 59923 1.0807 0.3568

Backed by latency-tracking. Further commits will update this comment.

@JoanFM
Copy link
Member

JoanFM commented Oct 7, 2021

Merging since there is something unrelated in the CI

@JoanFM JoanFM merged commit e86a86a into master Oct 7, 2021
@JoanFM JoanFM deleted the feat-more-progressbar-options branch October 7, 2021 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase component/logging size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants