Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix fastapi version #3612

Merged
merged 5 commits into from
Oct 8, 2021
Merged

fix: fix fastapi version #3612

merged 5 commits into from
Oct 8, 2021

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Oct 8, 2021

No description provided.

@JoanFM JoanFM requested a review from hanxiao as a code owner October 8, 2021 10:36
@github-actions github-actions bot added size/XS area/setup This issue/PR affects setting up Jina labels Oct 8, 2021
@JoanFM JoanFM requested a review from jacobowitz October 8, 2021 10:37
@JoanFM JoanFM closed this Oct 8, 2021
@JoanFM JoanFM reopened this Oct 8, 2021
@github-actions github-actions bot added area/core This issue/PR affects the core codebase component/resource labels Oct 8, 2021
@github-actions github-actions bot removed area/core This issue/PR affects the core codebase component/resource labels Oct 8, 2021
@codecov
Copy link

codecov bot commented Oct 8, 2021

Codecov Report

Merging #3612 (dfe5a66) into master (e86a86a) will increase coverage by 1.78%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3612      +/-   ##
==========================================
+ Coverage   87.65%   89.44%   +1.78%     
==========================================
  Files         154      154              
  Lines       11544    11544              
==========================================
+ Hits        10119    10325     +206     
+ Misses       1425     1219     -206     
Flag Coverage Δ
daemon 45.07% <ø> (+5.09%) ⬆️
jina 88.65% <ø> (+3.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/peapods/pods/k8s.py 78.57% <0.00%> (+0.42%) ⬆️
jina/peapods/runtimes/gateway/http/models.py 100.00% <0.00%> (+0.74%) ⬆️
jina/types/routing/table.py 94.06% <0.00%> (+0.84%) ⬆️
jina/types/message/__init__.py 87.37% <0.00%> (+1.45%) ⬆️
jina/clients/base/http.py 96.49% <0.00%> (+1.75%) ⬆️
jina/helper.py 83.12% <0.00%> (+2.15%) ⬆️
jina/jaml/helper.py 85.36% <0.00%> (+2.43%) ⬆️
jina/peapods/pods/compound.py 82.71% <0.00%> (+2.46%) ⬆️
.../runtimes/request_handlers/data_request_handler.py 93.24% <0.00%> (+2.70%) ⬆️
jina/peapods/peas/helper.py 89.23% <0.00%> (+3.07%) ⬆️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 471fdc6...dfe5a66. Read the comment docs.

@JoanFM JoanFM closed this Oct 8, 2021
@JoanFM JoanFM reopened this Oct 8, 2021
@github-actions github-actions bot added area/core This issue/PR affects the core codebase component/resource labels Oct 8, 2021
@github-actions
Copy link

github-actions bot commented Oct 8, 2021

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1073, delta to last 2 avg.: -14%
  • 🐢🐢 query QPS at 48, delta to last 2 avg.: -10%
  • 🐢🐢 dam extend QPS at 40073, delta to last 2 avg.: -18%
  • 🐢🐢 avg flow time within 1.1675 seconds, delta to last 2 avg.: -25%
  • 🐎🐎🐎🐎 import jina within 0.5099 seconds, delta to last 2 avg.: +17%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1073 48 40073 1.1675 0.5099
2.1.5 1422 62 55906 1.3934 0.37
2.1.4 1087 44 42159 1.7304 0.498

Backed by latency-tracking. Further commits will update this comment.

extra-requirements.txt Outdated Show resolved Hide resolved
Co-authored-by: Tobias Jacobowitz <tobias.jacobowitz@jina.ai>
@JoanFM JoanFM closed this Oct 8, 2021
@JoanFM JoanFM reopened this Oct 8, 2021
extra-requirements.txt Outdated Show resolved Hide resolved
@JoanFM JoanFM merged commit 4eb1d98 into master Oct 8, 2021
@JoanFM JoanFM deleted the fix-fastapi branch October 8, 2021 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/setup This issue/PR affects setting up Jina component/resource size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants