Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(daemon): workaround failing jinad ci #3623

Merged
merged 1 commit into from
Oct 9, 2021
Merged

fix(daemon): workaround failing jinad ci #3623

merged 1 commit into from
Oct 9, 2021

Conversation

jacobowitz
Copy link
Contributor

@jacobowitz jacobowitz commented Oct 9, 2021

This is a workaround for the failing jinad tests in CI.
In this debug pr I noticed that it takes longer than 10 seconds to start the docker containers with the peas. I dont know why this is and it seems too long to me. We should probably investigate what is happening there, but might just be CI not having powerful enough machines for all the docker image build and container handling.

As a workaround this PR increases the container run timeout from 10 seconds to 30 seconds. I hope that makes CI more stable.
This mitigates #3610

@codecov
Copy link

codecov bot commented Oct 9, 2021

Codecov Report

Merging #3623 (e337fdd) into master (4eb1d98) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3623      +/-   ##
==========================================
+ Coverage   89.40%   89.43%   +0.02%     
==========================================
  Files         154      154              
  Lines       11544    11546       +2     
==========================================
+ Hits        10321    10326       +5     
+ Misses       1223     1220       -3     
Flag Coverage Δ
daemon 45.06% <ø> (-0.01%) ⬇️
jina 88.64% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/clients/base/grpc.py 63.82% <0.00%> (-6.39%) ⬇️
jina/peapods/runtimes/prefetch/gateway.py 91.83% <0.00%> (-2.05%) ⬇️
jina/peapods/pods/k8slib/kubernetes_tools.py 90.69% <0.00%> (-1.17%) ⬇️
jina/types/arrays/traversable.py 90.32% <0.00%> (+0.32%) ⬆️
jina/helper.py 83.12% <0.00%> (+0.35%) ⬆️
jina/clients/base/http.py 98.24% <0.00%> (+1.75%) ⬆️
jina/peapods/runtimes/gateway/http/__init__.py 100.00% <0.00%> (+2.77%) ⬆️
jina/peapods/runtimes/jinad/__init__.py 90.74% <0.00%> (+3.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eb1d98...e337fdd. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Oct 9, 2021

Latency summary

Current PR yields:

  • 🐎🐎🐎🐎 index QPS at 1233, delta to last 2 avg.: +14%
  • 🐎🐎🐎🐎 query QPS at 56, delta to last 2 avg.: +20%
  • 🐎🐎🐎🐎 dam extend QPS at 48740, delta to last 2 avg.: +25%
  • 🐎🐎🐎🐎 avg flow time within 1.6627 seconds, delta to last 2 avg.: +15%
  • 🐢🐢 import jina within 0.4394 seconds, delta to last 2 avg.: -7%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1233 56 48740 1.6627 0.4394
2.1.5 1077 48 38395 1.1787 0.4803
2.1.4 1081 44 39288 1.7096 0.469

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM merged commit 4e7536e into master Oct 9, 2021
@JoanFM JoanFM deleted the fix-jinad-tests branch October 9, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants