Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: draft image search via text #3832

Merged
merged 6 commits into from
Nov 13, 2021
Merged

Conversation

azayz
Copy link
Contributor

@azayz azayz commented Oct 29, 2021

closes #3794

@github-actions
Copy link

This PR closes: #3794

@github-actions github-actions bot added size/XS area/docs This issue/PR affects the docs labels Oct 29, 2021
@codecov
Copy link

codecov bot commented Oct 29, 2021

Codecov Report

Merging #3832 (347b0b8) into master (b90f7a9) will increase coverage by 0.09%.
The diff coverage is n/a.

❗ Current head 347b0b8 differs from pull request most recent head b517f4e. Consider uploading reports for the commit b517f4e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3832      +/-   ##
==========================================
+ Coverage   88.55%   88.64%   +0.09%     
==========================================
  Files         160      156       -4     
  Lines       12125    12132       +7     
==========================================
+ Hits        10737    10755      +18     
+ Misses       1388     1377      -11     
Flag Coverage Δ
daemon 44.39% <ø> (+0.35%) ⬆️
jina 88.55% <ø> (+1.96%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/peapods/pods/k8slib/kubernetes_tools.py 67.41% <0.00%> (-29.22%) ⬇️
jina/peapods/networking.py 58.33% <0.00%> (-28.44%) ⬇️
jina/peapods/pods/k8s.py 62.53% <0.00%> (-18.74%) ⬇️
jina/types/ndarray/__init__.py 80.00% <0.00%> (-12.40%) ⬇️
jina/peapods/pods/k8slib/kubernetes_deployment.py 84.00% <0.00%> (-10.67%) ⬇️
jina/types/arrays/document.py 87.76% <0.00%> (-4.99%) ⬇️
jina/types/mixin.py 91.17% <0.00%> (-4.98%) ⬇️
jina/clients/mixin.py 97.50% <0.00%> (-2.50%) ⬇️
jina/types/document/converters.py 76.51% <0.00%> (-1.07%) ⬇️
jina/executors/__init__.py 83.65% <0.00%> (-0.83%) ⬇️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b90f7a9...b517f4e. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Oct 29, 2021

Latency summary

Current PR yields:

  • 😶 index QPS at 1148, delta to last 2 avg.: +2%
  • 😶 query QPS at 51, delta to last 2 avg.: +3%
  • 😶 dam extend QPS at 33962, delta to last 2 avg.: +2%
  • 😶 avg flow time within 1.4086 seconds, delta to last 2 avg.: -11%
  • 🐢🐢 import jina within 0.4674 seconds, delta to last 2 avg.: -8%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1148 51 33962 1.4086 0.4674
2.4.2 1147 50 34245 1.5613 0.5125
2.4.1 1093 48 31748 1.6182 0.5098

Backed by latency-tracking. Further commits will update this comment.

@github-actions github-actions bot added the size/M label Nov 9, 2021
@azayz azayz requested review from JoanFM and hanxiao November 9, 2021 11:42
Copy link
Member

@CatStark CatStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still some typos. Could you check it with a spell-checker?

docs/datatype/image/text2image.md Outdated Show resolved Hide resolved
docs/datatype/image/text2image.md Outdated Show resolved Hide resolved
docs/datatype/image/text2image.md Outdated Show resolved Hide resolved
docs/datatype/image/text2image.md Outdated Show resolved Hide resolved
docs/datatype/image/text2image.md Outdated Show resolved Hide resolved
docs/datatype/image/text2image.md Outdated Show resolved Hide resolved
Copy link
Member

@alexcg1 alexcg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pay special attention to capitalization, punctuation. Many other small changes

docs/datatype/image/text2image.md Outdated Show resolved Hide resolved
docs/datatype/image/text2image.md Outdated Show resolved Hide resolved
docs/datatype/image/text2image.md Outdated Show resolved Hide resolved
docs/datatype/image/text2image.md Outdated Show resolved Hide resolved
docs/datatype/image/text2image.md Outdated Show resolved Hide resolved
docs/datatype/image/text2image.md Outdated Show resolved Hide resolved
docs/datatype/image/text2image.md Outdated Show resolved Hide resolved
docs/datatype/image/text2image.md Outdated Show resolved Hide resolved
docs/datatype/image/text2image.md Outdated Show resolved Hide resolved
docs/datatype/image/text2image.md Outdated Show resolved Hide resolved
docs/datatype/image/text2image.md Outdated Show resolved Hide resolved
docs/datatype/image/text2image.md Outdated Show resolved Hide resolved
docs/datatype/image/text2image.md Outdated Show resolved Hide resolved
docs/datatype/image/text2image.md Outdated Show resolved Hide resolved
docs/datatype/image/text2image.md Outdated Show resolved Hide resolved
docs/datatype/image/text2image.md Outdated Show resolved Hide resolved
docs/datatype/image/text2image.md Outdated Show resolved Hide resolved
makram93
makram93 previously approved these changes Nov 11, 2021
Copy link
Member

@alexcg1 alexcg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! I caught a few more things this time round, but after these changes I think we're good to go!

docs/datatype/image/text2image.md Outdated Show resolved Hide resolved
docs/datatype/image/text2image.md Outdated Show resolved Hide resolved
docs/datatype/image/text2image.md Show resolved Hide resolved
docs/datatype/image/text2image.md Outdated Show resolved Hide resolved
docs/datatype/image/text2image.md Outdated Show resolved Hide resolved
docs/datatype/image/text2image.md Outdated Show resolved Hide resolved
docs/datatype/image/text2image.md Outdated Show resolved Hide resolved
docs/datatype/image/text2image.md Outdated Show resolved Hide resolved
docs/datatype/image/text2image.md Outdated Show resolved Hide resolved
docs/datatype/image/text2image.md Outdated Show resolved Hide resolved
@github-actions
Copy link

📝 Docs are deployed on https://docs-add-image-search-clip-3794--jina-docs.netlify.app 🎉

Copy link
Member

@hanxiao hanxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not visible, make sure you add it to TOC

Copy link
Member

@alexcg1 alexcg1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@azayz azayz requested a review from hanxiao November 12, 2021 12:35
@azayz azayz requested a review from makram93 November 12, 2021 12:35
Copy link
Member

@makram93 makram93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@hanxiao hanxiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

never mind, i found it

@hanxiao hanxiao merged commit 6ed6f0b into master Nov 13, 2021
@hanxiao hanxiao deleted the docs-add-image-search-clip-3794 branch November 13, 2021 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs This issue/PR affects the docs size/M size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tutorial on image-search using CLIP
6 participants