Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): fix location and bounding box in converters #3847

Merged
merged 2 commits into from
Nov 1, 2021

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Nov 1, 2021

No description provided.

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase component/type labels Nov 1, 2021
@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #3847 (3febaa8) into master (8af5786) will decrease coverage by 0.67%.
The diff coverage is 0.00%.

❗ Current head 3febaa8 differs from pull request most recent head 153c9f4. Consider uploading reports for the commit 153c9f4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3847      +/-   ##
==========================================
- Coverage   87.77%   87.09%   -0.68%     
==========================================
  Files         156      156              
  Lines       12223    12224       +1     
==========================================
- Hits        10729    10647      -82     
- Misses       1494     1577      +83     
Flag Coverage Δ
daemon 44.30% <0.00%> (+0.01%) ⬆️
jina 86.61% <0.00%> (+2.80%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/types/document/converters.py 77.99% <0.00%> (-0.77%) ⬇️
jina/peapods/networking.py 58.33% <0.00%> (-24.02%) ⬇️
jina/peapods/pods/k8slib/kubernetes_tools.py 67.41% <0.00%> (-16.86%) ⬇️
jina/peapods/pods/k8s.py 62.53% <0.00%> (-16.83%) ⬇️
jina/peapods/pods/k8slib/kubernetes_deployment.py 84.00% <0.00%> (-10.67%) ⬇️
jina/executors/decorators.py 94.54% <0.00%> (-5.46%) ⬇️
jina/flow/base.py 73.07% <0.00%> (-5.02%) ⬇️
jina/peapods/runtimes/jinad/__init__.py 80.86% <0.00%> (-4.35%) ⬇️
jina/importer.py 84.61% <0.00%> (-2.57%) ⬇️
jina/clients/base/http.py 94.87% <0.00%> (-2.57%) ⬇️
... and 22 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8af5786...153c9f4. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Nov 1, 2021

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1017, delta to last 2 avg.: -10%
  • 🐢🐢 query QPS at 49, delta to last 2 avg.: -8%
  • 🐢🐢 dam extend QPS at 36127, delta to last 2 avg.: -14%
  • 🐢🐢 avg flow time within 1.6039 seconds, delta to last 2 avg.: +7%
  • 🐎🐎🐎🐎 import jina within 0.5235 seconds, delta to last 2 avg.: +13%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1017 49 36127 1.6039 0.5235
2.2.2 1223 58 46592 1.393 0.4401
2.2.1 1042 49 38220 1.6005 0.4855

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 6104e4b into master Nov 1, 2021
@hanxiao hanxiao deleted the fix-location-in-sliding-winder branch November 1, 2021 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase component/type size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant