Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): fix all zeros and near zero sparse ravel #3903

Merged
merged 1 commit into from
Nov 10, 2021

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Nov 10, 2021

No description provided.

@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type labels Nov 10, 2021
@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #3903 (de79b85) into master (e0dff8c) will increase coverage by 0.18%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3903      +/-   ##
==========================================
+ Coverage   88.57%   88.75%   +0.18%     
==========================================
  Files         160      160              
  Lines       12145    12144       -1     
==========================================
+ Hits        10757    10778      +21     
+ Misses       1388     1366      -22     
Flag Coverage Δ
daemon 43.95% <12.50%> (+<0.01%) ⬆️
jina 85.68% <100.00%> (-0.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/__init__.py 71.60% <100.00%> (ø)
jina/types/ndarray/__init__.py 93.17% <100.00%> (-0.04%) ⬇️
jina/peapods/runtimes/container/helper.py 64.28% <0.00%> (-23.81%) ⬇️
jina/peapods/pods/k8slib/kubernetes_client.py 70.58% <0.00%> (-23.53%) ⬇️
jina/peapods/peas/__init__.py 73.40% <0.00%> (-13.30%) ⬇️
jina/peapods/pods/k8slib/kubernetes_tools.py 84.26% <0.00%> (-12.36%) ⬇️
jina/peapods/runtimes/container/__init__.py 73.21% <0.00%> (-7.15%) ⬇️
jina/clients/base/websocket.py 89.65% <0.00%> (-6.90%) ⬇️
jina/peapods/runtimes/zmq/zed.py 87.67% <0.00%> (-3.66%) ⬇️
jina/peapods/runtimes/base.py 80.64% <0.00%> (-3.23%) ⬇️
... and 20 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c80a9a...de79b85. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1193, delta to last 2 avg.: +2%
  • 😶 query QPS at 53, delta to last 2 avg.: +3%
  • 😶 dam extend QPS at 34307, delta to last 2 avg.: +1%
  • 😶 avg flow time within 1.3956 seconds, delta to last 2 avg.: +9%
  • 😶 import jina within 0.4687 seconds, delta to last 2 avg.: +2%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1193 53 34307 1.3956 0.4687
2.4.2 1142 50 32405 1.4381 0.4675
2.4.1 1189 52 35354 1.1227 0.4431

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit dd3091a into master Nov 10, 2021
@hanxiao hanxiao deleted the fix-allzero-nearzero branch November 10, 2021 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing component/type size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant