Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix signal handling from __init__ streamlit #3909

Merged
merged 1 commit into from
Nov 10, 2021
Merged

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Nov 10, 2021

No description provided.

@JoanFM JoanFM requested a review from hanxiao as a code owner November 10, 2021 17:43
@github-actions github-actions bot added size/XS area/core This issue/PR affects the core codebase area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality labels Nov 10, 2021
@codecov
Copy link

codecov bot commented Nov 10, 2021

Codecov Report

Merging #3909 (580da54) into master (dd3091a) will increase coverage by 1.07%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3909      +/-   ##
==========================================
+ Coverage   88.66%   89.74%   +1.07%     
==========================================
  Files         160      160              
  Lines       12144    12147       +3     
==========================================
+ Hits        10768    10901     +133     
+ Misses       1376     1246     -130     
Flag Coverage Δ
daemon 43.95% <50.00%> (-0.01%) ⬇️
jina 88.19% <50.00%> (+1.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/__init__.py 70.23% <50.00%> (-1.37%) ⬇️
jina/clients/base/grpc.py 70.21% <0.00%> (-14.90%) ⬇️
jina/peapods/zmq/__init__.py 89.06% <0.00%> (-0.70%) ⬇️
jina/jaml/__init__.py 95.47% <0.00%> (+0.41%) ⬆️
jina/peapods/runtimes/jinad/__init__.py 81.73% <0.00%> (+0.86%) ⬆️
jina/peapods/runtimes/zmq/zed.py 92.23% <0.00%> (+1.36%) ⬆️
jina/types/message/__init__.py 87.37% <0.00%> (+1.45%) ⬆️
jina/jaml/parsers/flow/v1.py 98.24% <0.00%> (+1.75%) ⬆️
jina/peapods/pods/__init__.py 85.65% <0.00%> (+2.20%) ⬆️
jina/jaml/helper.py 85.36% <0.00%> (+2.43%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd3091a...580da54. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 😶 index QPS at 1200, delta to last 2 avg.: -4%
  • 😶 query QPS at 52, delta to last 2 avg.: -5%
  • 😶 dam extend QPS at 34654, delta to last 2 avg.: -4%
  • 😶 avg flow time within 1.5741 seconds, delta to last 2 avg.: +25%
  • 🐢🐢 import jina within 0.4343 seconds, delta to last 2 avg.: -12%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1200 52 34654 1.5741 0.4343
2.4.2 1183 50 32072 1.4136 0.5269
2.4.1 1327 58 40872 1.0872 0.4619

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit 872684a into master Nov 10, 2021
@hanxiao hanxiao deleted the main-signal-handle branch November 10, 2021 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/entrypoint This issue/PR affects the entrypoint codebase area/helper This issue/PR affects the helper functionality size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants