Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(types): use mixin to refactor document class #3919

Merged
merged 6 commits into from
Nov 11, 2021
Merged

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Nov 11, 2021

No description provided.

@github-actions github-actions bot added size/XL area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/client component/proto component/type labels Nov 11, 2021
@hanxiao hanxiao closed this Nov 11, 2021
@hanxiao hanxiao reopened this Nov 11, 2021
@codecov
Copy link

codecov bot commented Nov 11, 2021

Codecov Report

Merging #3919 (da0d0ad) into master (dd3091a) will increase coverage by 0.82%.
The diff coverage is 79.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3919      +/-   ##
==========================================
+ Coverage   88.66%   89.49%   +0.82%     
==========================================
  Files         160      174      +14     
  Lines       12144    12285     +141     
==========================================
+ Hits        10768    10994     +226     
+ Misses       1376     1291      -85     
Flag Coverage Δ
daemon 43.93% <30.15%> (-0.03%) ⬇️
jina 87.96% <79.38%> (+1.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/proto/jina_pb2.py 100.00% <ø> (ø)
jina/types/arrays/chunk.py 88.00% <ø> (-0.89%) ⬇️
jina/types/arrays/mixins/__init__.py 100.00% <ø> (ø)
jina/types/arrays/mixins/match.py 93.93% <ø> (-0.07%) ⬇️
jina/types/list.py 100.00% <ø> (ø)
jina/types/struct.py 100.00% <ø> (ø)
jina/clients/request/__init__.py 77.27% <28.57%> (-22.73%) ⬇️
jina/types/document/mixins/dump.py 35.71% <35.71%> (ø)
jina/types/document/graph.py 92.45% <50.00%> (-0.36%) ⬇️
jina/types/document/__init__.py 84.32% <53.08%> (-7.84%) ⬇️
... and 37 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd3091a...da0d0ad. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Nov 11, 2021

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1188, delta to last 2 avg.: -11%
  • 🐢🐢 query QPS at 53, delta to last 2 avg.: -10%
  • 🐢🐢 dam extend QPS at 33878, delta to last 2 avg.: -17%
  • 🐢🐢 avg flow time within 1.3888 seconds, delta to last 2 avg.: +23%
  • 😶 import jina within 0.4471 seconds, delta to last 2 avg.: -2%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1188 53 33878 1.3888 0.4471
2.4.2 1519 66 46823 1.071 0.4047
2.4.1 1167 51 35021 1.1787 0.5098

Backed by latency-tracking. Further commits will update this comment.

@github-actions
Copy link

📝 Docs are deployed on https://doc-improve-dcos--jina-docs.netlify.app 🎉

@hanxiao hanxiao merged commit 440e3c7 into master Nov 11, 2021
@hanxiao hanxiao deleted the doc-improve-dcos branch November 11, 2021 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/client component/proto component/type size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants