Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(types): traversal_paths is now a comma-sep string #3925

Merged
merged 1 commit into from
Nov 13, 2021

Conversation

hanxiao
Copy link
Member

@hanxiao hanxiao commented Nov 13, 2021

Based on the considerations:

@github-actions github-actions bot added size/M area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs area/testing This issue/PR affects testing component/type labels Nov 13, 2021
@codecov
Copy link

codecov bot commented Nov 13, 2021

Codecov Report

Merging #3925 (958dca1) into master (5915342) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3925      +/-   ##
==========================================
- Coverage   88.88%   88.84%   -0.04%     
==========================================
  Files         176      176              
  Lines       12376    12384       +8     
==========================================
+ Hits        11000    11003       +3     
- Misses       1376     1381       +5     
Flag Coverage Δ
daemon 43.70% <9.09%> (-0.01%) ⬇️
jina 86.91% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/types/arrays/mixins/traverse.py 90.27% <100.00%> (-0.35%) ⬇️
jina/peapods/peas/__init__.py 84.57% <0.00%> (-2.66%) ⬇️
jina/peapods/runtimes/jinad/__init__.py 80.86% <0.00%> (-1.74%) ⬇️
jina/peapods/runtimes/zmq/zed.py 90.86% <0.00%> (-0.46%) ⬇️
jina/peapods/pods/__init__.py 85.65% <0.00%> (+0.22%) ⬆️
jina/clients/base/__init__.py 88.57% <0.00%> (+1.42%) ⬆️
jina/importer.py 87.17% <0.00%> (+2.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5915342...958dca1. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1246, delta to last 2 avg.: -6%
  • 🐢🐢 query QPS at 52, delta to last 2 avg.: -12%
  • 🐢🐢 dam extend QPS at 35565, delta to last 2 avg.: -10%
  • 🐢🐢 avg flow time within 1.5855 seconds, delta to last 2 avg.: +36%
  • 😶 import jina within 0.4539 seconds, delta to last 2 avg.: +2%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1246 52 35565 1.5855 0.4539
2.4.3 1337 56 37766 1.2398 0.4647
2.4.2 1316 62 42125 1.0865 0.4174

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit b6ba8bf into master Nov 13, 2021
@hanxiao hanxiao deleted the refactor-traversal-paths-str branch November 13, 2021 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs area/testing This issue/PR affects testing component/type size/M
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant