Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: remove jinad deployment from cd #3927

Merged
merged 1 commit into from Nov 15, 2021
Merged

ci: remove jinad deployment from cd #3927

merged 1 commit into from Nov 15, 2021

Conversation

deepankarm
Copy link
Member

No description provided.

@github-actions github-actions bot added size/S area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Nov 14, 2021
@codecov
Copy link

codecov bot commented Nov 14, 2021

Codecov Report

Merging #3927 (e73c631) into master (6ed6f0b) will decrease coverage by 0.23%.
The diff coverage is 67.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3927      +/-   ##
==========================================
- Coverage   89.55%   89.31%   -0.24%     
==========================================
  Files         176      180       +4     
  Lines       12384    12495     +111     
==========================================
+ Hits        11090    11160      +70     
- Misses       1294     1335      +41     
Flag Coverage Δ
daemon 43.29% <0.72%> (-0.39%) ⬇️
jina 87.81% <67.15%> (-0.23%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/math/distance/torch.py 58.33% <58.33%> (ø)
jina/math/distance/tensorflow.py 61.90% <61.90%> (ø)
jina/math/distance/__init__.py 66.66% <66.66%> (ø)
jina/math/distance/paddle.py 77.77% <77.77%> (ø)
jina/math/distance/numpy.py 94.11% <80.00%> (ø)
jina/__init__.py 70.23% <100.00%> (ø)
jina/types/arrays/mixins/match.py 94.00% <100.00%> (+0.06%) ⬆️
jina/peapods/peas/__init__.py 84.57% <0.00%> (-2.13%) ⬇️
jina/peapods/runtimes/zmq/zed.py 91.32% <0.00%> (-0.46%) ⬇️
jina/clients/base/grpc.py 82.22% <0.00%> (+15.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ea4033b...e73c631. Read the comment docs.

@github-actions
Copy link

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1117, delta to last 2 avg.: -14%
  • 🐢🐢 query QPS at 48, delta to last 2 avg.: -18%
  • 🐢🐢 dam extend QPS at 31490, delta to last 2 avg.: -20%
  • 🐢🐢 avg flow time within 1.586 seconds, delta to last 2 avg.: +17%
  • 🐎🐎🐎🐎 import jina within 0.5055 seconds, delta to last 2 avg.: +18%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1117 48 31490 1.586 0.5055
2.4.5 1318 59 39008 1.3433 0.3926
2.4.4 1280 57 40045 1.3617 0.4591

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM merged commit dc25083 into master Nov 15, 2021
@JoanFM JoanFM deleted the cd-remove-jinad branch November 15, 2021 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants