fix(client): assure error not called on done #3934
Merged
+37
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
size/S
area/core
JoanFM
reviewed
Nov 15, 2021
tests/unit/clients/test_helper.py
Outdated
|
|
||
|
|
||
| @pytest.fixture | ||
| def flow(): |
Latency summaryCurrent PR yields:
Breakdown
Backed by latency-tracking. Further commits will update this comment. |
Codecov Report
@@ Coverage Diff @@
## master #3934 +/- ##
==========================================
+ Coverage 88.86% 89.07% +0.20%
==========================================
Files 180 180
Lines 12627 12627
==========================================
+ Hits 11221 11247 +26
+ Misses 1406 1380 -26
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
deepankarm
requested changes
Nov 15, 2021
jina/clients/helper.py
Outdated
| @@ -79,7 +79,7 @@ def callback_exec( | |||
| """ | |||
| if on_error and response.status.code >= jina_pb2.StatusProto.ERROR: | |||
| _safe_callback(on_error, continue_on_error, logger)(response) | |||
| elif on_done: | |||
| elif on_done and response.status.code < jina_pb2.StatusProto.ERROR: | |||
There was a problem hiding this comment.
Suggested change
| elif on_done and response.status.code < jina_pb2.StatusProto.ERROR: | |
| elif on_done and response.status.code == jina_pb2.StatusProto.SUCCESS: |
JoanFM
requested changes
Nov 15, 2021
tests/unit/clients/test_helper.py
Outdated
| '', on_done=on_done_mock, on_error=on_error_mock, on_always=on_always_mock | ||
| ) | ||
| on_always_mock.assert_called_once() | ||
| on_done_mock.assert_not_called() |
There was a problem hiding this comment.
do these asserts outside the context, otherwise if exception test may pass
JoanFM
approved these changes
Nov 15, 2021
deepankarm
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.