Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(daemon): scale endpoint for flows & pods #3935

Merged
merged 8 commits into from Nov 16, 2021
Merged

Conversation

deepankarm
Copy link
Member

@deepankarm deepankarm commented Nov 15, 2021

  • Separated the rolling_update & scale endpoints for Flows / Pods.
  • Separated rolling_update & scale methods for JinaDClient.
  • Removed UpdateOperation enums.
  • Added unittests for scale store, partial-store & client.
  • Added distributed tests for scale endpoints (Local Flow-remote Executor, Remote Flow, Remote Pod)

image

@deepankarm deepankarm marked this pull request as draft November 15, 2021 17:40
@github-actions github-actions bot added size/L area/core This issue/PR affects the core codebase area/daemon area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/peapod labels Nov 15, 2021
@codecov
Copy link

codecov bot commented Nov 15, 2021

Codecov Report

Merging #3935 (8513cd4) into master (df57ce1) will increase coverage by 0.69%.
The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3935      +/-   ##
==========================================
+ Coverage   88.34%   89.04%   +0.69%     
==========================================
  Files         180      180              
  Lines       12627    12629       +2     
==========================================
+ Hits        11155    11245      +90     
+ Misses       1472     1384      -88     
Flag Coverage Δ
daemon 43.43% <25.00%> (+0.49%) ⬆️
jina 87.28% <75.00%> (+1.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/peapods/runtimes/jinad/__init__.py 88.88% <75.00%> (+8.01%) ⬆️
jina/peapods/runtimes/zmq/asyncio.py 84.12% <0.00%> (-1.59%) ⬇️
jina/helper.py 83.27% <0.00%> (+0.17%) ⬆️
jina/peapods/pods/__init__.py 85.22% <0.00%> (+0.19%) ⬆️
jina/jaml/__init__.py 95.47% <0.00%> (+0.41%) ⬆️
jina/peapods/runtimes/zmq/zed.py 91.78% <0.00%> (+0.45%) ⬆️
jina/peapods/peas/__init__.py 85.10% <0.00%> (+0.53%) ⬆️
jina/peapods/zmq/__init__.py 90.46% <0.00%> (+0.69%) ⬆️
jina/clients/base/__init__.py 87.32% <0.00%> (+1.40%) ⬆️
jina/types/message/__init__.py 87.01% <0.00%> (+1.44%) ⬆️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df57ce1...8513cd4. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Nov 15, 2021

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1115, delta to last 2 avg.: -18%
  • 🐢🐢 query QPS at 48, delta to last 2 avg.: -19%
  • 🐢🐢 dam extend QPS at 32461, delta to last 2 avg.: -20%
  • 🐢🐢 avg flow time within 1.5924 seconds, delta to last 2 avg.: +45%
  • 🐎🐎🐎🐎 import jina within 0.551 seconds, delta to last 2 avg.: +22%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1115 48 32461 1.5924 0.551
2.4.5 1219 52 36425 1.1153 0.5112
2.4.4 1502 66 45442 1.0742 0.3869

Backed by latency-tracking. Further commits will update this comment.

@github-actions github-actions bot added size/XL area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Nov 16, 2021
@deepankarm deepankarm linked an issue Nov 16, 2021 that may be closed by this pull request
4 tasks
@deepankarm deepankarm changed the title feat(daemon): scale endpoint feat(daemon): scale endpoint for flows & pods Nov 16, 2021
@deepankarm deepankarm marked this pull request as ready for review November 16, 2021 08:42
Copy link
Member

@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am missing some unittests about the new scale endpoint

@deepankarm deepankarm force-pushed the feat-scale-via-jinad branch 4 times, most recently from 075d336 to 8cb2b1d Compare November 16, 2021 12:38
@deepankarm deepankarm marked this pull request as ready for review November 16, 2021 17:12
@JoanFM JoanFM merged commit 3957743 into master Nov 16, 2021
@JoanFM JoanFM deleted the feat-scale-via-jinad branch November 16, 2021 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cicd This issue/PR affects the cicd pipeline area/core This issue/PR affects the core codebase area/daemon area/housekeeping This issue/PR is housekeeping area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/peapod size/L size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add distribuetd test for scale method
2 participants