Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(documentarray): use production api #4050

Merged
merged 1 commit into from
Dec 9, 2021
Merged

fix(documentarray): use production api #4050

merged 1 commit into from
Dec 9, 2021

Conversation

mapleeit
Copy link
Member

@mapleeit mapleeit commented Dec 9, 2021

No description provided.

@github-actions github-actions bot added size/XS area/core This issue/PR affects the core codebase component/type labels Dec 9, 2021
@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #4050 (ae1b6fa) into master (223aa20) will decrease coverage by 0.90%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4050      +/-   ##
==========================================
- Coverage   88.15%   87.24%   -0.91%     
==========================================
  Files         186      186              
  Lines       13128    13128              
==========================================
- Hits        11573    11454     -119     
- Misses       1555     1674     +119     
Flag Coverage Δ
daemon 43.09% <100.00%> (+0.06%) ⬆️
jina 85.15% <100.00%> (-1.30%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/__init__.py 70.23% <100.00%> (ø)
jina/types/arrays/mixins/io/pushpull.py 98.33% <100.00%> (ø)
jina/flow/base.py 75.99% <0.00%> (-13.91%) ⬇️
jina/jaml/parsers/__init__.py 92.85% <0.00%> (-7.15%) ⬇️
jina/peapods/pods/compound.py 80.11% <0.00%> (-6.63%) ⬇️
.../runtimes/request_handlers/data_request_handler.py 88.60% <0.00%> (-5.07%) ⬇️
jina/jaml/helper.py 82.92% <0.00%> (-2.44%) ⬇️
jina/peapods/pods/__init__.py 83.23% <0.00%> (-2.00%) ⬇️
jina/jaml/parsers/flow/v1.py 96.49% <0.00%> (-1.76%) ⬇️
jina/peapods/peas/__init__.py 85.10% <0.00%> (-1.60%) ⬇️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e797a2...ae1b6fa. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Dec 9, 2021

Latency summary

Current PR yields:

  • 🐎🐎 index QPS at 1375, delta to last 2 avg.: +9%
  • 🐎🐎🐎🐎 query QPS at 28, delta to last 2 avg.: +20%
  • 🐎🐎🐎🐎 dam extend QPS at 41265, delta to last 2 avg.: +19%
  • 🐎🐎🐎🐎 avg flow time within 1.087 seconds, delta to last 2 avg.: -31%
  • 😶 import jina within 0.4144 seconds, delta to last 2 avg.: +0%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1375 28 41265 1.087 0.4144
2.5.5 1126 21 31307 1.6298 0.4712
2.5.4 1380 25 37997 1.5653 0.3636

Backed by latency-tracking. Further commits will update this comment.

@hanxiao hanxiao merged commit bbac0aa into master Dec 9, 2021
@hanxiao hanxiao deleted the mapleeit-patch-1 branch December 9, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase component/type size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants