Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: modify unit test case for apply #4052

Merged
merged 5 commits into from
Dec 10, 2021
Merged

test: modify unit test case for apply #4052

merged 5 commits into from
Dec 10, 2021

Conversation

makram93
Copy link
Member

@makram93 makram93 commented Dec 9, 2021

update the test case for apply()

@github-actions github-actions bot added size/S area/testing This issue/PR affects testing labels Dec 9, 2021
@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #4052 (0613a4f) into master (bbac0aa) will increase coverage by 0.48%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4052      +/-   ##
==========================================
+ Coverage   88.33%   88.82%   +0.48%     
==========================================
  Files         186      186              
  Lines       13128    13128              
==========================================
+ Hits        11597    11661      +64     
+ Misses       1531     1467      -64     
Flag Coverage Δ
daemon 43.06% <ø> (ø)
jina 87.12% <ø> (+0.48%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/peapods/runtimes/zmq/zed.py 91.78% <0.00%> (ø)
jina/helper.py 83.97% <0.00%> (+0.17%) ⬆️
jina/flow/base.py 93.21% <0.00%> (+1.32%) ⬆️
jina/peapods/zmq/__init__.py 90.46% <0.00%> (+1.39%) ⬆️
jina/peapods/runtimes/jinad/__init__.py 88.88% <0.00%> (+1.70%) ⬆️
jina/peapods/peas/__init__.py 87.23% <0.00%> (+2.65%) ⬆️
jina/peapods/pods/__init__.py 88.42% <0.00%> (+3.19%) ⬆️
jina/peapods/pods/compound.py 90.05% <0.00%> (+3.31%) ⬆️
jina/types/arrays/mixins/parallel.py 64.91% <0.00%> (+35.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bbac0aa...0613a4f. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Dec 9, 2021

Latency summary

Current PR yields:

  • 🐎🐎🐎🐎 index QPS at 1727, delta to last 2 avg.: +45%
  • 🐎🐎🐎🐎 query QPS at 34, delta to last 2 avg.: +42%
  • 🐎🐎🐎🐎 dam extend QPS at 50551, delta to last 2 avg.: +42%
  • 🐎🐎🐎🐎 avg flow time within 1.3117 seconds, delta to last 2 avg.: -17%
  • 🐢🐢 import jina within 0.3537 seconds, delta to last 2 avg.: -19%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1727 34 50551 1.3117 0.3537
2.5.5 1120 20 30994 1.6102 0.4653
2.5.4 1256 26 39727 1.5634 0.4085

Backed by latency-tracking. Further commits will update this comment.

@makram93 makram93 closed this Dec 9, 2021
@makram93 makram93 reopened this Dec 9, 2021
Copy link
Member

@bwanglzu bwanglzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JoanFM JoanFM merged commit f2d2ae4 into master Dec 10, 2021
@JoanFM JoanFM deleted the test-unit-apply-test branch December 10, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing This issue/PR affects testing size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants