Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: do not update doc on merge to master but on release #4123

Merged
merged 1 commit into from
Jan 4, 2022

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Jan 4, 2022

No description provided.

@github-actions github-actions bot added size/S area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping labels Jan 4, 2022
@codecov
Copy link

codecov bot commented Jan 4, 2022

Codecov Report

Merging #4123 (5bff87b) into master (56af142) will increase coverage by 0.98%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4123      +/-   ##
==========================================
+ Coverage   86.95%   87.94%   +0.98%     
==========================================
  Files         125      125              
  Lines        9644     9644              
==========================================
+ Hits         8386     8481      +95     
+ Misses       1258     1163      -95     
Flag Coverage Δ
daemon 49.47% <100.00%> (ø)
jina 85.61% <100.00%> (+0.98%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/__init__.py 70.58% <100.00%> (ø)
jina/peapods/runtimes/container/__init__.py 80.35% <0.00%> (-1.79%) ⬇️
jina/peapods/runtimes/zmq/zed.py 91.78% <0.00%> (ø)
jina/helper.py 82.72% <0.00%> (+0.52%) ⬆️
jina/peapods/peas/__init__.py 85.10% <0.00%> (+0.53%) ⬆️
jina/jaml/helper.py 85.36% <0.00%> (+0.81%) ⬆️
jina/peapods/zmq/__init__.py 90.46% <0.00%> (+1.39%) ⬆️
jina/parsers/helloworld.py 96.15% <0.00%> (+1.92%) ⬆️
jina/peapods/runtimes/gateway/http/__init__.py 100.00% <0.00%> (+2.70%) ⬆️
jina/peapods/pods/compound.py 90.16% <0.00%> (+3.27%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ddf49f...5bff87b. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jan 4, 2022

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1196, delta to last 2 avg.: -22%
  • 🐢🐢 query QPS at 20, delta to last 2 avg.: -33%
  • 🐢🐢 dam extend QPS at 31459, delta to last 2 avg.: -32%
  • 🐢🐢 avg flow time within 1.1388 seconds, delta to last 2 avg.: -12%
  • 🐎🐎🐎🐎 import jina within 0.42 seconds, delta to last 2 avg.: +14%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1196 20 31459 1.1388 0.42
2.6.4 1549 30 47495 1.55 0.3837
2.6.3 1552 29 45438 1.0671 0.3528

Backed by latency-tracking. Further commits will update this comment.

Copy link
Contributor

@tadejsv tadejsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoanFM JoanFM merged commit 15dfcdf into master Jan 4, 2022
@JoanFM JoanFM deleted the cd-doc-update branch January 4, 2022 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cicd This issue/PR affects the cicd pipeline area/housekeeping This issue/PR is housekeeping size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants