Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: flow post return DocumentArray #4137

Merged
merged 21 commits into from
Jan 11, 2022
Merged

feat: flow post return DocumentArray #4137

merged 21 commits into from
Jan 11, 2022

Conversation

JohannesMessner
Copy link
Contributor

No description provided.

@github-actions github-actions bot added size/M area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs area/testing This issue/PR affects testing component/client labels Jan 7, 2022
@codecov
Copy link

codecov bot commented Jan 7, 2022 •
edited

Codecov Report

Merging #4137 (c67ff86) into master (cdc62c3) will increase coverage by 4.73%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4137      +/-   ##
==========================================
+ Coverage   81.78%   86.51%   +4.73%     
==========================================
  Files         118      118              
  Lines        8329     8338       +9     
==========================================
+ Hits         6812     7214     +402     
+ Misses       1517     1124     -393
Flag Coverage Δ
daemon 42.09% <16.66%> (+2.98%) ⬆️
jina 85.65% <83.33%> (+4.91%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/clients/__init__.py 90.90% <ø> (ø)
jina/flow/base.py 90.68% <ø> (+2.10%) ⬆️
jina/clients/mixin.py 90.47% <80.00%> (-3.65%) ⬇️
jina/clients/base/__init__.py 87.32% <100.00%> (+1.40%) ⬆️
jina/parsers/client.py 100.00% <100.00%> (ø)
jina/enums.py 96.62% <0.00%> (+0.67%) ⬆️
jina/hubble/helper.py 90.30% <0.00%> (+1.02%) ⬆️
jina/helper.py 81.50% <0.00%> (+1.02%) ⬆️
jina/optimizers/parameters.py 93.68% <0.00%> (+1.05%) ⬆️
.../runtimes/request_handlers/data_request_handler.py 92.63% <0.00%> (+1.05%) ⬆️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 379d972...c67ff86. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jan 7, 2022 •
edited

Latency summary

Current PR yields:

  • 😶 index QPS at 1222, delta to last 2 avg.: +1%
  • 🐢🐢 query QPS at 21, delta to last 2 avg.: -7%
  • 🐢🐢 dam extend QPS at 40267, delta to last 2 avg.: +17%
  • 🐢🐢 avg flow time within 1.9671 seconds, delta to last 2 avg.: +35%
  • 🐢🐢 import jina within 0.3966 seconds, delta to last 2 avg.: -18%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1222 21 40267 1.9671 0.3966
2.6.4 1280 25 37868 1.3062 0.4406
2.6.3 1126 19 30466 1.6038 0.5315

Backed by latency-tracking. Further commits will update this comment.

@JoanFM JoanFM changed the title Feat flow doc return feat: flow post return DocumentArray Jan 7, 2022
JoanFM
JoanFM requested changes Jan 8, 2022
View reviewed changes
Copy link
Member

@JoanFM JoanFM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not add result_as_docarray option in Client

jina/clients/base/__init__.py Outdated Show resolved Hide resolved
JoanFM
JoanFM requested changes Jan 10, 2022
View reviewed changes
jina/clients/__init__.py Show resolved Hide resolved
@github-actions github-actions bot added the area/cli This issue/PR affects the command line interface label Jan 10, 2022
@JohannesMessner JohannesMessner marked this pull request as ready for review January 11, 2022 09:39
JoanFM
JoanFM requested changes Jan 11, 2022
View reviewed changes
jina/clients/mixin.py Outdated Show resolved Hide resolved
@JoanFM JoanFM closed this Jan 11, 2022
@JoanFM JoanFM reopened this Jan 11, 2022
@github-actions
Copy link

📝 Docs are deployed on https://feat-flow-doc-return--jina-docs.netlify.app 🎉

JoanFM
JoanFM approved these changes Jan 11, 2022
View reviewed changes
jina/clients/__init__.py
@@ -22,6 +22,7 @@ def Client(
port: Optional[int] = None,
protocol: Optional[str] = 'GRPC',
proxy: Optional[bool] = False,
results_as_docarray: Optional[bool] = False,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
results_as_docarray: Optional[bool] = False,
results_as_docarray: bool = False,

@JoanFM JoanFM merged commit def0a12 into master Jan 11, 2022
@JoanFM JoanFM deleted the feat-flow-doc-return branch January 11, 2022 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoanFM JoanFM JoanFM approved these changes

Assignees
No one assigned
Labels
area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/docs This issue/PR affects the docs area/testing This issue/PR affects testing component/client component/flow size/L size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JohannesMessner @JoanFM @jina-bot