Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clean up replica set #4141

Merged
merged 2 commits into from
Jan 7, 2022
Merged

refactor: clean up replica set #4141

merged 2 commits into from
Jan 7, 2022

Conversation

jacobowitz
Copy link
Contributor

Closes https://github.com/jina-ai/internal-tasks/issues/370

We had both head_args and the head itself in the ReplicaSet. Both is redundant. We need the head so I removed the head_args and get them from the head instead

@jacobowitz jacobowitz requested a review from JoanFM January 7, 2022 10:58
@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality component/peapod labels Jan 7, 2022
@github-actions
Copy link

github-actions bot commented Jan 7, 2022

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1029, delta to last 2 avg.: -21%
  • 🐢🐢 query QPS at 18, delta to last 2 avg.: -17%
  • 🐢🐢 dam extend QPS at 28537, delta to last 2 avg.: -17%
  • 🐢🐢 avg flow time within 1.5458 seconds, delta to last 2 avg.: +15%
  • 🐎🐎🐎🐎 import jina within 0.4893 seconds, delta to last 2 avg.: +14%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1029 18 28537 1.5458 0.4893
2.6.4 1231 22 33125 1.1402 0.4377
2.6.3 1398 21 35889 1.5402 0.4133

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #4141 (08d3dc3) into master (3976695) will increase coverage by 0.82%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4141      +/-   ##
==========================================
+ Coverage   86.55%   87.37%   +0.82%     
==========================================
  Files         125      120       -5     
  Lines        9644     8697     -947     
==========================================
- Hits         8347     7599     -748     
+ Misses       1297     1098     -199     
Flag Coverage Δ
daemon 42.25% <43.97%> (-7.28%) ⬇️
jina 84.77% <87.42%> (+2.45%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/excepts.py 100.00% <ø> (ø)
jina/helloworld/chatbot/app.py 82.97% <ø> (-0.70%) ⬇️
jina/parsers/peapods/pea.py 100.00% <ø> (ø)
jina/parsers/peapods/pod.py 100.00% <ø> (ø)
jina/parsers/ping.py 100.00% <ø> (ø)
jina/peapods/peas/container_helper.py 73.80% <ø> (ø)
jina/peapods/runtimes/base.py 74.19% <ø> (-6.46%) ⬇️
jina/proto/jina_pb2.py 58.10% <46.55%> (-41.90%) ⬇️
jina/peapods/runtimes/__init__.py 61.11% <55.55%> (+4.58%) ⬆️
jina/peapods/pods/k8s.py 80.66% <74.13%> (+1.11%) ⬆️
... and 69 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 933415b...08d3dc3. Read the comment docs.

@JoanFM JoanFM changed the title feat: clean up replica set refactor: clean up replica set Jan 7, 2022
JoanFM
JoanFM previously approved these changes Jan 7, 2022
@github-actions github-actions bot added the area/testing This issue/PR affects testing label Jan 7, 2022
@JoanFM JoanFM merged commit 3617467 into master Jan 7, 2022
@JoanFM JoanFM deleted the feat-replicase-cleanup branch January 7, 2022 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/peapod size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants