Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: close peas correctly #4142

Merged
merged 2 commits into from
Jan 7, 2022
Merged

fix: close peas correctly #4142

merged 2 commits into from
Jan 7, 2022

Conversation

jacobowitz
Copy link
Contributor

It can happen that a Pod closes a Pea before it was started (meaning its worker process has not yet been started). We should not wait for its termination then.

@jacobowitz jacobowitz requested a review from JoanFM January 7, 2022 15:22
@github-actions github-actions bot added size/S area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/peapod labels Jan 7, 2022
@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #4142 (d89e687) into master (3976695) will increase coverage by 0.66%.
The diff coverage is 89.63%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4142      +/-   ##
==========================================
+ Coverage   86.55%   87.21%   +0.66%     
==========================================
  Files         125      120       -5     
  Lines        9644     8681     -963     
==========================================
- Hits         8347     7571     -776     
+ Misses       1297     1110     -187     
Flag Coverage Δ
daemon 42.19% <44.76%> (-7.34%) ⬇️
jina 84.61% <87.20%> (+2.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/excepts.py 100.00% <ø> (ø)
jina/helloworld/chatbot/app.py 82.97% <ø> (-0.70%) ⬇️
jina/parsers/peapods/pea.py 100.00% <ø> (ø)
jina/parsers/peapods/pod.py 100.00% <ø> (ø)
jina/parsers/ping.py 100.00% <ø> (ø)
jina/peapods/peas/container_helper.py 73.80% <ø> (ø)
jina/peapods/runtimes/base.py 74.19% <ø> (-6.46%) ⬇️
jina/proto/jina_pb2.py 58.10% <46.55%> (-41.90%) ⬇️
jina/peapods/runtimes/__init__.py 61.11% <55.55%> (+4.58%) ⬆️
jina/peapods/pods/k8s.py 80.66% <74.13%> (+1.11%) ⬆️
... and 70 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 933415b...d89e687. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Jan 7, 2022

Latency summary

Current PR yields:

  • 🐎🐎 index QPS at 1199, delta to last 2 avg.: +6%
  • 🐎🐎🐎🐎 query QPS at 23, delta to last 2 avg.: +11%
  • 🐎🐎🐎🐎 dam extend QPS at 37091, delta to last 2 avg.: +14%
  • 🐎🐎🐎🐎 avg flow time within 1.1285 seconds, delta to last 2 avg.: -15%
  • 😶 import jina within 0.4483 seconds, delta to last 2 avg.: +1%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1199 23 37091 1.1285 0.4483
2.6.4 1128 20 33005 1.1507 0.4456
2.6.3 1129 20 31840 1.5261 0.4413

Backed by latency-tracking. Further commits will update this comment.

@jacobowitz jacobowitz merged commit 0f285ae into master Jan 7, 2022
@jacobowitz jacobowitz deleted the fix-pea-close branch January 7, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/network This issue/PR affects network functionality area/testing This issue/PR affects testing component/peapod size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants