Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use absolute imports #4167

Merged
merged 3 commits into from
Jan 12, 2022
Merged

refactor: use absolute imports #4167

merged 3 commits into from
Jan 12, 2022

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Jan 12, 2022

No description provided.

@github-actions github-actions bot added size/XL area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/network This issue/PR affects network functionality component/client component/executor component/flow component/jaml component/logging component/peapod component/proto component/type executor/meta labels Jan 12, 2022
@github-actions
Copy link

github-actions bot commented Jan 12, 2022

Latency summary

Current PR yields:

  • 🐢🐢 index QPS at 1225, delta to last 2 avg.: -17%
  • 🐢🐢 query QPS at 21, delta to last 2 avg.: -23%
  • 🐢🐢 dam extend QPS at 40413, delta to last 2 avg.: -4%
  • 🐢🐢 avg flow time within 1.4094 seconds, delta to last 2 avg.: +16%
  • 🐎🐎 import jina within 0.3999 seconds, delta to last 2 avg.: +8%

Breakdown

Version Index QPS Query QPS DAM Extend QPS Avg Flow Time (s) Import Time (s)
current 1225 21 40413 1.4094 0.3999
2.6.4 1244 22 33260 1.1168 0.42
2.6.3 1735 32 51806 1.3113 0.3154

Backed by latency-tracking. Further commits will update this comment.

@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #4167 (d05970e) into master (def0a12) will increase coverage by 0.98%.
The diff coverage is 89.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4167      +/-   ##
==========================================
+ Coverage   86.53%   87.52%   +0.98%     
==========================================
  Files         118      120       +2     
  Lines        8338     8574     +236     
==========================================
+ Hits         7215     7504     +289     
+ Misses       1123     1070      -53     
Flag Coverage Δ
daemon 40.91% <38.82%> (-1.20%) ⬇️
jina 86.73% <89.14%> (+1.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
jina/jaml/parsers/base.py 60.00% <0.00%> (ø)
jina/types/request/__init__.py 100.00% <ø> (ø)
jina/proto/jina_pb2.py 58.10% <3.33%> (ø)
jina/clients/mixin.py 90.47% <25.00%> (ø)
jina/flow/builder.py 80.00% <33.33%> (ø)
jina/parsers/helper.py 45.18% <50.00%> (-0.34%) ⬇️
jina/peapods/runtimes/__init__.py 61.11% <54.54%> (ø)
jina/clients/base/helper.py 85.71% <60.00%> (ø)
jina/peapods/runtimes/head/__init__.py 91.85% <61.53%> (+4.06%) ⬆️
jina/clients/request/__init__.py 73.91% <66.66%> (ø)
... and 101 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 782f106...d05970e. Read the comment docs.

@JoanFM JoanFM merged commit cea3006 into master Jan 12, 2022
@JoanFM JoanFM deleted the more-absolute-imports branch January 12, 2022 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/cli This issue/PR affects the command line interface area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/network This issue/PR affects network functionality component/client component/executor component/flow component/jaml component/logging component/peapod component/proto component/type executor/meta size/XL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant